From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Jim Meyering <jim@meyering.net>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Use "do...while (0)", not "if (1)..else" in macro definitions.
Date: Tue, 05 Feb 2008 08:09:30 +0100 [thread overview]
Message-ID: <47A80BAA.6070609@swipnet.se> (raw)
In-Reply-To: <87myqgbghd.fsf@rho.meyering.net>
Jim Meyering skrev:
>> 2008-01-28 Jim Meyering <meyering@redhat.com>
>>
>> Use "do...while (0)", not "if (1)..else" in macro definitions.
>> The latter provokes a warning from gcc about the empty else, when
>> followed by ";". Also, without that trailing semicolon, it would
>> silently swallow up any following statement.
>> * syntax.h (SETUP_SYNTAX_TABLE):
>> (SETUP_SYNTAX_TABLE_FOR_OBJECT): Likewise.
>> * buffer.h (DECODE_POSITION): Likewise.
>> * charset.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
>> (FETCH_STRING_CHAR_ADVANCE_NO_CHECK): Likewise.
>> (FETCH_CHAR_ADVANCE): Likewise.
>
> Ping?
>
> http://thread.gmane.org/gmane.emacs.devel/87706
>
I'll put this in when the merge activities settle down a bit.
Jan D.
next prev parent reply other threads:[~2008-02-05 7:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 13:19 [PATCH] Use "do...while (0)", not "if (1)..else" in macro definitions Jim Meyering
2008-02-04 20:42 ` Jim Meyering
2008-02-05 7:09 ` Jan Djärv [this message]
2008-02-07 12:56 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A80BAA.6070609@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).