unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>,
	"'Barry Fishman'" <barry_fishman@acm.org>
Cc: emacs-devel@gnu.org
Subject: RE: "Warning: `save-excursion' defeated by `set-buffer'" madness
Date: Mon, 15 Feb 2010 13:56:56 -0800	[thread overview]
Message-ID: <47A31A2B358F4F34B980D9EDC9672B18@us.oracle.com> (raw)
In-Reply-To: <jwvk4ue8e8u.fsf-monnier+emacs@gnu.org>

> Good, so the code that triggers the warning is in bbdb-com.el.
> But the code that runs the byte-compiler (and hence causes those
> harmless/informative warnings to turn into annoying windows 
> popping up) is in advice.el.
> 
> I've just installed the patch below which should fix your problem.

I would have thought that you would consider this annoyance to be a feature,
drawing attention as it does so well to code that you consider worth warning
about. ;-)

So now, to suppress this one annoyance, you've removed all byte-compiler
warnings for byte-compiling advice. I don't necessarily disagree, but are you
sure that's TRT? Should this perhaps be configurable by users of advice (e.g.
defadvice)? (Dunno.)





      parent reply	other threads:[~2010-02-15 21:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12 20:40 "Warning: `save-excursion' defeated by `set-buffer'" madness Štěpán Němec
     [not found] ` <m3zl3c3fl4.fsf@barry_fishman.acm.org>
2010-02-14  0:17   ` Štěpán Němec
     [not found]     ` <jwvfx53n5jm.fsf-monnier+emacs@gnu.org>
2010-02-14 19:38       ` Barry Fishman
2010-02-15 11:19         ` Štěpán Němec
2010-02-15 15:44           ` Drew Adams
     [not found]           ` <jwv3a12bmqj.fsf-monnier+emacs@gnu.org>
2010-02-15 15:50             ` Štěpán Němec
2010-02-15 17:53               ` Drew Adams
     [not found]               ` <jwvk4ue8e8u.fsf-monnier+emacs@gnu.org>
2010-02-15 21:56                 ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47A31A2B358F4F34B980D9EDC9672B18@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=barry_fishman@acm.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).