Need help with defmacro

Need help with defmacro

[Lennart Borgman (gmail)]

When I try to do instrument my-test-err4 below for edebug with

    C-u C-M-x

I get an error saying

     edebug-syntax-error: Invalid read syntax: "Expected", (&rest
         &or (symbolp &optional form) symbolp)

Can someone please explain to me what I have done wrong here?


(defvar mumamo-use-condition-case nil)
(make-variable-buffer-local 'mumamo-use-condition-case)
(put 'mumamo-use-condition-case 'permanent-local t)

(defvar mumamo-debugger 'mumamo-debug-to-backtrace)
(make-variable-buffer-local 'mumamo-debugger)
(put 'mumamo-debugger 'permanent-local t)

(defmacro mumamo-condition-case (var body-form &rest handlers)
   "Like `condition-case', but optional.
If `mumamo-use-condition-case' is nil then just evaluate
BODY. Otherwise do the same thing as

   (condition-case VAR
       BODY
     HANDLERS)."
   (declare (indent 2) (debug let))
   `(if (not mumamo-use-condition-case)
        (let* ((debugger mumamo-debugger)
               (debug-on-error (if debugger t debug-on-error)))
          ,body-form)
     (condition-case ,var
         ,body-form
       ,@handlers)))

(defun my-test-err4 ()
   (interactive)
   (mumamo-condition-case err
       (my-errx)
     (arith-error (message "here"))
     (error (message "%s, %s" err (error-message-string err)))
     ))

Re: Need help with defmacro

[Stefan Monnier]

> When I try to do instrument my-test-err4 below for edebug with

>    C-u C-M-x

> I get an error saying

>     edebug-syntax-error: Invalid read syntax: "Expected", (&rest
>         &or (symbolp &optional form) symbolp)

> Can someone please explain to me what I have done wrong here?

It's because you've told edebug that mumamo-condition-case has the same
syntax as `let', but then you go on and use it very differently.
You need to fix your `debug' declaration.


        Stefan

Re: Need help with defmacro

[Lennart Borgman (gmail)]

Stefan Monnier wrote:
>> When I try to do instrument my-test-err4 below for edebug with
> 
>>    C-u C-M-x
> 
>> I get an error saying
> 
>>     edebug-syntax-error: Invalid read syntax: "Expected", (&rest
>>         &or (symbolp &optional form) symbolp)
> 
>> Can someone please explain to me what I have done wrong here?
> 
> It's because you've told edebug that mumamo-condition-case has the same
> syntax as `let', but then you go on and use it very differently.
> You need to fix your `debug' declaration.


Thanks, I see - at least what to do. But the (debug ...) form is still 
mysterious.