From: martin rudalics <rudalics@gmx.at>
To: Phil Sung <psung@mit.edu>
Cc: emacs-pretest-bug@gnu.org
Subject: Re: 23.0.50; Deleting files in wdired does not work
Date: Fri, 25 Jan 2008 14:17:21 +0100 [thread overview]
Message-ID: <4799E161.4020404@gmx.at> (raw)
In-Reply-To: <60c603510801250216r7f62a876s37a86719d46d7633@mail.gmail.com>
> The following works for me, assuming (wdired-get-filename t)
> ought to return "" rather than nil on a deleted filename:
Looks good, thank you. I think this ought to return "" here because nil
should be reserved for `wdired-get-filename' was not able to figure out
the user's intentions from the text it found there. And marking a file
for deletion is a fairly dangerous undertaking.
If no one objects I'll install this in Emacs 22.2 in a couple of days.
Meanwhile you could do two things:
- Use
(string-equal (wdired-get-filename t) "")
instead of
(zerop (length (wdired-get-filename t)))
because the latter will return t when `wdired-get-filename' returns nil.
- Add a couple of comments documenting what was wrong and what you have
done to fix it.
Thanks again.
next prev parent reply other threads:[~2008-01-25 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 5:41 23.0.50; Deleting files in wdired does not work Phil Sung
2008-01-25 7:35 ` martin rudalics
2008-01-25 10:16 ` Phil Sung
2008-01-25 13:17 ` martin rudalics [this message]
2008-01-25 22:43 ` Phil Sung
2008-01-26 17:27 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4799E161.4020404@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-pretest-bug@gnu.org \
--cc=psung@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).