From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Davis Herring" Newsgroups: gmane.emacs.devel Subject: Re: `save-excursion' defeated by `set-buffer' Date: Mon, 4 Jan 2010 09:08:53 -0800 (PST) Message-ID: <47994.130.55.118.19.1262624933.squirrel@webmail.lanl.gov> References: <87aaxdqwqv.fsf@regnitz.physics.niu.edu> Reply-To: herring@lanl.gov NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1262625207 900 80.91.229.12 (4 Jan 2010 17:13:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Jan 2010 17:13:27 +0000 (UTC) Cc: emacs-devel@gnu.org, Roland Winkler To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 04 18:13:19 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NRqUS-0006MQ-Pm for ged-emacs-devel@m.gmane.org; Mon, 04 Jan 2010 18:13:13 +0100 Original-Received: from localhost ([127.0.0.1]:43474 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRqUT-0008MV-8V for ged-emacs-devel@m.gmane.org; Mon, 04 Jan 2010 12:13:13 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRqQu-00050m-VR for emacs-devel@gnu.org; Mon, 04 Jan 2010 12:09:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRqQq-0004xa-1z for emacs-devel@gnu.org; Mon, 04 Jan 2010 12:09:32 -0500 Original-Received: from [199.232.76.173] (port=45524 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRqQp-0004xW-Rp for emacs-devel@gnu.org; Mon, 04 Jan 2010 12:09:27 -0500 Original-Received: from proofpoint2.lanl.gov ([204.121.3.26]:34270) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NRqQp-0007US-Cf for emacs-devel@gnu.org; Mon, 04 Jan 2010 12:09:27 -0500 Original-Received: from mailrelay2.lanl.gov (mailrelay2.lanl.gov [128.165.4.103]) by proofpoint2.lanl.gov (8.14.3/8.14.3) with ESMTP id o04H8rOe003167; Mon, 4 Jan 2010 10:08:53 -0700 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by mailrelay2.lanl.gov (Postfix) with ESMTP id D579F15DB10B; Mon, 4 Jan 2010 10:08:53 -0700 (MST) X-NIE-2-Virus-Scanner: amavisd-new at mailrelay2.lanl.gov Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay2.lanl.gov (Postfix) with ESMTP id C1BD515DB107; Mon, 4 Jan 2010 10:08:53 -0700 (MST) Original-Received: by webmail1.lanl.gov (Postfix, from userid 48) id BEF481DE020B; Mon, 4 Jan 2010 10:08:53 -0700 (MST) Original-Received: from 130.55.118.19 (SquirrelMail authenticated user 196434) by webmail.lanl.gov with HTTP; Mon, 4 Jan 2010 09:08:53 -0800 (PST) In-Reply-To: User-Agent: SquirrelMail/1.4.8-5.7.lanl7 X-Priority: 3 (Normal) Importance: Normal X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5, 1.2.40, 4.0.166 definitions=2010-01-04_06:2009-12-31, 2010-01-04, 2010-01-04 signatures=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119378 Archived-At: > save-excursion only saves point in the current buffer, so > > (save-excursion (set-buffer foo) (goto-char (point-min))) > > will move point in foo and the point-saving done by save-excursion is > useless. So either you want to use If we know that (eq foo (current-buffer)), we should drop the `set-buffer'. If we know that not to be the case, we should use `with-current-buffer' (or perhaps `save-current-buffer'). But what if it could but needn't be? Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.