From: "Davis Herring" <herring@lanl.gov>
To: "Stefan Monnier" <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org,
Roland Winkler <roland.winkler@physik.uni-erlangen.de>
Subject: Re: `save-excursion' defeated by `set-buffer'
Date: Mon, 4 Jan 2010 09:08:53 -0800 (PST) [thread overview]
Message-ID: <47994.130.55.118.19.1262624933.squirrel@webmail.lanl.gov> (raw)
In-Reply-To: <jwvtyvk4agh.fsf-monnier+emacs@gnu.org>
> save-excursion only saves point in the current buffer, so
>
> (save-excursion (set-buffer foo) (goto-char (point-min)))
>
> will move point in foo and the point-saving done by save-excursion is
> useless. So either you want to use
If we know that (eq foo (current-buffer)), we should drop the
`set-buffer'. If we know that not to be the case, we should use
`with-current-buffer' (or perhaps `save-current-buffer'). But what if it
could but needn't be?
Davis
--
This product is sold by volume, not by mass. If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.
next prev parent reply other threads:[~2010-01-04 17:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 19:19 `save-excursion' defeated by `set-buffer' Roland Winkler
2009-12-21 15:26 ` Stefan Monnier
2009-12-21 16:23 ` David Kastrup
2009-12-22 12:51 ` martin rudalics
2009-12-23 0:45 ` Stefan Monnier
2009-12-23 9:07 ` David Kastrup
2009-12-24 4:35 ` Stefan Monnier
2009-12-24 9:03 ` David Kastrup
2009-12-29 16:01 ` Stefan Monnier
2010-01-04 9:09 ` Drew Adams
2010-01-04 18:30 ` Stefan Monnier
2010-01-05 20:17 ` David Kastrup
2010-01-06 0:02 ` Drew Adams
2010-01-06 4:20 ` Stefan Monnier
2010-01-06 8:07 ` David Kastrup
2010-01-06 8:57 ` Drew Adams
2010-01-10 4:57 ` Stefan Monnier
2010-01-10 8:12 ` David Kastrup
2010-01-10 21:43 ` Stefan Monnier
2010-01-11 8:24 ` David Kastrup
2010-01-11 9:21 ` martin rudalics
2010-01-11 16:50 ` Stefan Monnier
2010-01-10 17:03 ` Drew Adams
2010-01-10 4:51 ` Stefan Monnier
2010-01-10 15:58 ` Harald Hanche-Olsen
2010-01-10 18:05 ` martin rudalics
2010-01-10 18:06 ` Drew Adams
2010-01-10 19:44 ` Harald Hanche-Olsen
2009-12-24 14:04 ` Roland Winkler
2010-01-04 17:08 ` Davis Herring [this message]
2010-01-04 17:34 ` David Kastrup
2010-01-04 18:33 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2009-12-18 9:20 Eli Zaretskii
2009-12-18 15:29 ` Juanma Barranquero
2009-12-18 15:58 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47994.130.55.118.19.1262624933.squirrel@webmail.lanl.gov \
--to=herring@lanl.gov \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=roland.winkler@physik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).