From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.devel Subject: Re: Simple Tasks, new TODO category Date: Thu, 24 Jan 2008 01:41:04 +0100 Message-ID: <4797DEA0.9020309@gmail.com> References: <4797DC12.6070401@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1201135284 18167 80.91.229.12 (24 Jan 2008 00:41:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Jan 2008 00:41:24 +0000 (UTC) Cc: Dan Nicolaescu , Drew Adams , emacs-devel@gnu.org To: Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 24 01:41:44 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JHqA3-0000HH-QH for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2008 01:41:44 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHq9d-0000jp-OT for ged-emacs-devel@m.gmane.org; Wed, 23 Jan 2008 19:41:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHq9Z-0000hm-7E for emacs-devel@gnu.org; Wed, 23 Jan 2008 19:41:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHq9X-0000fr-0g for emacs-devel@gnu.org; Wed, 23 Jan 2008 19:41:12 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHq9W-0000fo-RU for emacs-devel@gnu.org; Wed, 23 Jan 2008 19:41:10 -0500 Original-Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JHq9S-0002nu-OH; Wed, 23 Jan 2008 19:41:07 -0500 Original-Received: from c83-254-148-228.bredband.comhem.se ([83.254.148.228]:63595 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1JHq9Q-0002C7-9I; Thu, 24 Jan 2008 01:41:05 +0100 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 In-Reply-To: <4797DC12.6070401@gnu.org> X-Antivirus: avast! (VPS 080123-2, 2008-01-23), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.148.228 X-ACL-Warn: Too high rate of unknown addresses received from you X-Scan-Result: No virus found in message 1JHq9Q-0002C7-9I. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1JHq9Q-0002C7-9I 779a5b6397b94bdc145a80fc7c38d9ce X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87416 Archived-At: Jason Rumney wrote: > Drew Adams wrote: >>> Is there any drawback with such a simple design? Could we for example >>> use char number 1? It should be very easy to implement for w32 and the >>> other case above (where char 1 is just replaced with & and the other >>> case where it is replaced with _). >>> >> >> I haven't followed this. But I would be against having any (printable) >> character in a menu-item name be interpreted specially and not just >> treated >> as part of the name. It is not the case that some (printable) character >> "could not possibly be part of the title" - whatever (printable) >> character >> you choose, someone will want to use it in a menu item. `_' can >> certainly be >> useful in a name. >> > > I understood "char number 1" to mean \001 (C-q C-a), not the digit 1. > But I think that is too obscure, it would be better to explicitly define > the access key, as in (define-key ... '(menu-item ... :access-key ?a)). Perhaps nothing prevent doing that together with the underlying implementation I suggested? But more simple could then be to have a function (setq menu-string (add-acc menu-string ?a)) The advantage is of course easy implementation. It works immediately for both define-key and easymenu.