rng-auto.el seems to be missing from nxml-mode files

rng-auto.el seems to be missing from nxml-mode files

[Ismail Dönmez]

Hi all,

Now that finally emacs CVS merged nxml-mode support I went out to try it. But 
to my surprise rng-auto.el file is not included in lisp/nxml directory. This 
file is part of the original nxml distribution and needed for auto-validation 
of XML files via RELAX-NG.

Is there a reason why this file is not included? Because without that file 
most powerful feature of nxml-mode is missing.

Regards,
ismail

-- 
Never learn by your mistakes, if you do you may never dare to try again.

Re: rng-auto.el seems to be missing from nxml-mode files

[Lennart Borgman (gmail)]

Ismail Dönmez wrote:
> Hi all,
> 
> Now that finally emacs CVS merged nxml-mode support I went out to try it. But 
> to my surprise rng-auto.el file is not included in lisp/nxml directory. This 
> file is part of the original nxml distribution and needed for auto-validation 
> of XML files via RELAX-NG.
> 
> Is there a reason why this file is not included? Because without that file 
> most powerful feature of nxml-mode is missing.


Hi Ismail,

Ah, yes, I tested some days ago and wondered what was wrong. I do not 
know if it is good to split rng-auto.el, but here are some notes:

- The autoload has been moved somewhere else.

- Some variables are set in rgn-auto. Maybe these just can be moved to 
the defvars?

   (setq rng-preferred-prefix-alist-default ...)
   (setq rng-schema-loader-alist '(("rnc" . rng-c-load-schema)))

- There are some add-hook calls, maybe they can be moved to 
nxml-mode.el? (The first one of these starts validation.):

   (add-hook 'nxml-mode-hook 'rng-nxml-mode-init)
   (add-hook 'nxml-mode-hook 'nxml-enable-unicode-char-name-sets)

- I have no idea what to do with the auto-coding stuff. Does not that 
have to be loaded before nxml-mode is loaded since it is used when 
reading files?

   (require 'nxml-enc)
   ;; Install our own `set-auto-coding-function'.
   (nxml-start-auto-coding)

Re: rng-auto.el seems to be missing from nxml-mode files

[Ismail Dönmez]

Hi Lennart,

[...]
> - There are some add-hook calls, maybe they can be moved to
> nxml-mode.el? (The first one of these starts validation.):
>
>    (add-hook 'nxml-mode-hook 'rng-nxml-mode-init)
>    (add-hook 'nxml-mode-hook 'nxml-enable-unicode-char-name-sets)

Indeed the first hook to ~/.emacs get the auto-validation done but I think 
these should be in nxml-mode.el as you suggested to get the old behaviour 
back.

I am not familiar with the rest of the code so I'll let others to reply to 
rest of your mail.

Regards,
ismail

-- 
Never learn by your mistakes, if you do you may never dare to try again.

Re: rng-auto.el seems to be missing from nxml-mode files

[Jason Rumney]

Lennart Borgman (gmail) wrote:
> - The autoload has been moved somewhere else.
The autoloads should be in loaddefs.el now along with other built-in 
autoloads. You probably need to have bootstrapped (rather than just 
recompiled) since nxml was added to get loaddefs.el updated.

> - Some variables are set in rgn-auto. Maybe these just can be moved to 
> the defvars?
I did that a few weeks ago. Is there something I missed?

> - There are some add-hook calls, maybe they can be moved to 
> nxml-mode.el? (The first one of these starts validation.):
I think only these are missing now. Perhaps these should not be hooks if 
the intention is for them to always be enabled.

Re: rng-auto.el seems to be missing from nxml-mode files

[Ismail Dönmez]

Thursday 10 January 2008 20:26:10 tarihinde şunları yazmıştınız:
> > - There are some add-hook calls, maybe they can be moved to
> > nxml-mode.el? (The first one of these starts validation.):
>
> I think only these are missing now. Perhaps these should not be hooks if
> the intention is for them to always be enabled.

nxml's most important feature is on-the-fly validation so yes I thinks those 
should be always enabled.

Regards,
ismail

-- 
Never learn by your mistakes, if you do you may never dare to try again.

Re: rng-auto.el seems to be missing from nxml-mode files

[Ismail Dönmez]

Thursday 10 January 2008 20:26:10 tarihinde şunları yazmıştınız:
> > - There are some add-hook calls, maybe they can be moved to
> > nxml-mode.el? (The first one of these starts validation.):
>
> I think only these are missing now. Perhaps these should not be hooks if
> the intention is for them to always be enabled.

nxml's most important feature is on-the-fly validation so yes I think those 
should be always enabled.

Regards,
ismail

-- 
Never learn by your mistakes, if you do you may never dare to try again.

Re: rng-auto.el seems to be missing from nxml-mode files

[Lennart Borgman (gmail)]

Jason Rumney wrote:
> Lennart Borgman (gmail) wrote:
>> - The autoload has been moved somewhere else.
> The autoloads should be in loaddefs.el now along with other built-in 
> autoloads. You probably need to have bootstrapped (rather than just 
> recompiled) since nxml was added to get loaddefs.el updated.

Thanks, yes, that was what I tried to say.

>> - Some variables are set in rgn-auto. Maybe these just can be moved to 
>> the defvars?
> I did that a few weeks ago. Is there something I missed?

Ah, here is where I need to checkout/bootstrap ... ;-)

Thanks.

>> - There are some add-hook calls, maybe they can be moved to 
>> nxml-mode.el? (The first one of these starts validation.):
> I think only these are missing now. Perhaps these should not be hooks if 
> the intention is for them to always be enabled.

Maybe. I think there must be some reason that JK placed this in a hook, 
but I don't know what it is.

But what about the auto-coding stuff? Did you find some solution to that 
too? Maybe that could be used by html-mode/xml-mode as well?

Re: rng-auto.el seems to be missing from nxml-mode files

[Jason Rumney]

Lennart Borgman (gmail) wrote:
> Maybe. I think there must be some reason that JK placed this in a 
> hook, but I don't know what it is.
>
> But what about the auto-coding stuff? Did you find some solution to 
> that too? Maybe that could be used by html-mode/xml-mode as well?
Maybe I'm mistaken, but I think the auto-coding stuff just duplicates 
what is already done in sgml-xml-auto-coding-function. Maybe there are 
some improvements we can make to sgml-xml-auto-coding-function based 
what nxml does though, so it is worth comparing them before discarding 
the nxml version completely.

Re: rng-auto.el seems to be missing from nxml-mode files

[Lennart Borgman (gmail)]

Jason Rumney wrote:
> Lennart Borgman (gmail) wrote:
>> Maybe. I think there must be some reason that JK placed this in a 
>> hook, but I don't know what it is.
>>
>> But what about the auto-coding stuff? Did you find some solution to 
>> that too? Maybe that could be used by html-mode/xml-mode as well?
> Maybe I'm mistaken, but I think the auto-coding stuff just duplicates 
> what is already done in sgml-xml-auto-coding-function. Maybe there are 
> some improvements we can make to sgml-xml-auto-coding-function based 
> what nxml does though, so it is worth comparing them before discarding 
> the nxml version completely.

I took a quick look. It does not seem like find-auto-coding uses 
sgml-xml-auto-coding-function. How is that then handled on file reading?

I think nxml-mode checks coding both on reading and writing.

Re: rng-auto.el seems to be missing from nxml-mode files

[Jason Rumney]

Lennart Borgman (gmail) wrote:
> I took a quick look. It does not seem like find-auto-coding uses 
> sgml-xml-auto-coding-function. How is that then handled on file reading?
It is certainly used when I perform the following sequence of operations...

emacs -Q
M-x debug-on-entry sgml-xml-auto-coding-function
C-x C-f ~/.emacs

It also seems to be called after C-x C-s, so writing also seems to be 
covered.

Re: rng-auto.el seems to be missing from nxml-mode files

[Lennart Borgman (gmail)]

Jason Rumney wrote:
> Lennart Borgman (gmail) wrote:
>> I took a quick look. It does not seem like find-auto-coding uses 
>> sgml-xml-auto-coding-function. How is that then handled on file reading?
> It is certainly used when I perform the following sequence of operations...
> 
> emacs -Q
> M-x debug-on-entry sgml-xml-auto-coding-function
> C-x C-f ~/.emacs
> 
> It also seems to be called after C-x C-s, so writing also seems to be 
> covered.

Ok, fine. I did not look hard enough. Thanks for the little lesson above.

Re: rng-auto.el seems to be missing from nxml-mode files

[Richard Stallman]

What is the rng-auto.el file?  Could you show it to us?

Re: rng-auto.el seems to be missing from nxml-mode files

[Ismail Dönmez]

Hi,
Friday 11 January 2008 15:58:13 tarihinde Richard Stallman şunları yazmıştı:
> What is the rng-auto.el file?  Could you show it to us?

thanks to Lennart and Jason's explanations this file is no longer needed, just 
Jason should move some hooks to nxml-mode.el so that on the fly validation 
works as expected.

Thanks and Regards,
ismail


-- 
Never learn by your mistakes, if you do you may never dare to try again.