From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [Fwd: Frame Height Different for Default Frame and Additional Frames] Date: Fri, 28 Dec 2007 21:06:46 +0100 Message-ID: <47755756.20601@gmx.at> References: <002501c8044b$fcc95390$6100000a@intermedinc.internal> <4701F8AC.6070900@gmx.at> <470A9D22.2040709@gmx.at> <470BF1BF.3000609@gmx.at> <470C695D.5010906@swipnet.se> <470DE439.1030603@gmx.at> <470E655E.10905@swipnet.se> <4773F8BA.4090009@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1198872456 9620 80.91.229.12 (28 Dec 2007 20:07:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Dec 2007 20:07:36 +0000 (UTC) Cc: jan.h.d@swipnet.se, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 28 21:07:48 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J8LUa-0004H8-6J for ged-emacs-devel@m.gmane.org; Fri, 28 Dec 2007 21:07:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J8LUE-0005yy-Th for ged-emacs-devel@m.gmane.org; Fri, 28 Dec 2007 15:07:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J8LTx-0005m9-68 for emacs-devel@gnu.org; Fri, 28 Dec 2007 15:07:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J8LTw-0005lJ-A4 for emacs-devel@gnu.org; Fri, 28 Dec 2007 15:07:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J8LTv-0005l2-TQ for emacs-devel@gnu.org; Fri, 28 Dec 2007 15:06:59 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1J8LTv-0002eB-AF for emacs-devel@gnu.org; Fri, 28 Dec 2007 15:06:59 -0500 Original-Received: (qmail invoked by alias); 28 Dec 2007 20:06:57 -0000 Original-Received: from N796P000.adsl.highway.telekom.at (EHLO [62.47.43.96]) [62.47.43.96] by mail.gmx.net (mp007) with SMTP; 28 Dec 2007 21:06:57 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+Dv7s5dCuDg380RxKD5OD2Kfd95QtHCPBZoWiglO iGHW9kVRLr7vlr User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85559 Archived-At: > Perhaps I have misunderstood the nature of the problem. I thought the > problem was that the height in default-frame-alist was being ignored > entirely for the first frame, from these words: > > > Yes they do. It looks like default-frame-alist is ignored for the first frame. > > My experience is that it is not ignored. > > You're now talking about a completely different problem: Your experience and mine are identic but the problem goes as follows: The OP observed that the height of the initial (first) frame differs from that of additional frames. We found out that their heights differ by the height of the toolbar, that is, additional frames are by the height of the toolbar higher than the initial (first) frame. So if you say that the initial frame is good, the bug must be with the additional frames and _not_ with the initial one. Hence we've been discussing the problem with different premises. > Commenting out the following stretch from frame.c fixes the bug for me. > > /* This used to be done _before_ calling x_figure_window_size, but > since the height is reset here, this was really a no-op. I > assume that moving it here does what Gerd intended (although he > no longer can remember what that was... ++KFS, 2003-03-25. */ > .... > > I think that change causes another bug. The height in lines of an > Emacs frame is not supposed to include the tool bar. If you create a > frame and specify 40 lines, you should get 40 lines of text, plus a > tool bar. As Jan said this code is executed exclusively with the native toolbar, hence we would have to judge whether not executing that code DTRT for toolkit scrollbars. With the native toolbar, this code is not executed for the initial frame (at least not here), hence we would have to judge whether not executing that code for the initial frame does TRT. Here, this code gets executed only for additional frames and iff I have toolbars enabled. > The size of the initial frame seems correct because initial frames get > the same height regardless of whether they have a tool-bar or not (if > they didn't we'd probably have another bug). > > Could you explain that precisely? Perhaps that special feature for -g > and the initial frame needs to be implemented in a different place. Please recall that I didn't use -g to produce the bug, just a single-line .emacs containing (add-to-list 'default-frame-alist '(height . 37)) What I wanted to express above is that my initial Emacs frame has the same height regardless of whether I have toolbars enabled or not. Also, the heights of my frames never change when I switch toolbars on and off.