From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
To: rms@gnu.org
Cc: Per Abrahamsen <per.abrahamsen@gmail.com>,
drew.adams@oracle.com, emacs-devel@gnu.org
Subject: Re: custom type `color' is not enforced
Date: Sat, 22 Dec 2007 21:58:14 +0100 [thread overview]
Message-ID: <476D7A66.2080901@gmail.com> (raw)
In-Reply-To: <E1J5xrv-0001mx-Jn@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
Richard Stallman wrote:
> You have the right idea.
I have tried to finish the code too now ;-)
Please see the attached files. Beside a more complete widget type for
colors I have also included some basic functions for testing custom
types. I believe these could be useful.
I have tried to make them as clean and simple as they can be at the
moment. However I am unsure about how to call the :match and :validate
functions. I might very well be missing something concerning the
conversion from and to external values.
BTW when I have been looking at this I have had a hard time to
understand why there are both :match and :validate functions.
I also do not understand the paramters they take. Why do the :match
function have a widget parameter? Does it have something to do with
external - internal conversion, or?
[-- Attachment #2: color-test.el --]
[-- Type: text/plain, Size: 4004 bytes --]
(defun color-digits-p (color)
(save-match-data
(string-match (rx bos
"#"
(1+ (repeat 3 3 hex-digit))
eos)
color)))
(defun widget-color-match (widget value)
(or
;; I am not sure what colors to test. It might be relevant to check
;; all as I suggest here.
;;(color-defined-p val)
(member value x-colors)
(and (stringp value)
(color-digits-p value))))
(defun widget-color-validate (widget)
(let ((value (widget-value widget)))
(unless (widget-color-match widget value)
(widget-put widget :error (format "Invalid color: %S" value))
widget)))
(define-widget 'color 'editable-field
"Choose a color (with sample)."
:format "%{%t%}: %v (%{sample%})\n"
:size 25 ;; (length "light coldenrod yellow") = 22
:tag "Color"
:match 'widget-color-match
:validate 'widget-color-validate
:value "black"
:complete 'widget-color-complete
:sample-face-get 'widget-color-sample-face-get
:notify 'widget-color-notify
:action 'widget-color-action)
(defun custom-type-symbol-p (symbol custom-type)
"Return t if value of symbol SYMBOL should fit CUSTOM-TYPE."
(let ((found nil)
(type (get symbol 'custom-type)))
(while (and (not found) type)
(setq found (eq type custom-type))
(setq type (car (get type 'widget-type))))
found))
(defun custom-type-value-p (value custom-type)
"Return non-nil if value of VALUE fits CUSTOM-TYPE."
(let ((widget (if (listp custom-type)
custom-type
(list custom-type))))
(setq widget (widget-convert widget))
;; There are (unfortunately) two different ways to test the
;; values in a widget. Some widget types use both, some just one
;; of them. We check for both, but only use one of them here.
(let ((match-fun (widget-get widget :match))
(validate-fun (widget-get widget :validate)))
;;(setq match-fun nil)
;;(setq validate-fun nil)
(widget-put widget :value value)
;; Fix-me: I am not sure whether widget-apply of funcall
;; should be used here, but I believe anyone of them can be
;; used. But please look into this. It might have something to
;; do with internal/external values for the widgets.
(cond
;; Test the :match alternative first because this because this
;; seems most basic.
(match-fun
(when
;;(widget-apply widget :match value)
(funcall match-fun widget value)
t))
(validate-fun
(let (;;(val (widget-apply widget :validate))
(val (funcall validate-fun widget)))
;; Check if :error was applied
(when (not (widget-get val :error)) t)))
(t
(error
"There is no way to check value against custom type %s"
custom-type))))))
(defun custom-type-p (val-or-sym custom-type)
"Return non-nil if VAL-OR-SYM fits CUSTOM-TYPE.
VAL-OR-SYM may be either a variable or a symbol. If it is a
variable then return non-nil if the value fits custom type
CUSTOM-TYPE.
If it is a symbol then return non-nil if the values this symbol's
variable can have fits CUSTOM-TYPE."
(if (symbolp val-or-sym)
(custom-type-symbol-p val-or-sym custom-type)
(custom-type-value-p val-or-sym custom-type)))
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;; Tests
;; (custom-type-p 'test-color 'color)
;; (custom-type-p 'test-color 'edit)
;; (custom-type-p 'test-color 'editable-field)
;; (custom-type-p test-color 'color)
;; (get 'test-color 'custom-type)
;; (setq test-color "bla")
;; (setq test-color "black")
(defcustom test-color "black"
"color test"
:type 'color)
(defun max-color-length()
(let ((len 0)
(longest ""))
(mapc (lambda (color)
(when (< len (length color))
(setq len (length color))
(setq longest color)))
x-colors)
(cons len longest)))
;; (max-color-length)
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2007-12-22 20:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DNEMKBNJBGPAOPIJOOICAELMEBAA.drew.adams@oracle.com>
2007-12-18 23:00 ` custom type `color' is not enforced Drew Adams
2007-12-20 0:53 ` Richard Stallman
2007-12-20 1:27 ` Lennart Borgman (gmail)
2007-12-21 3:04 ` Richard Stallman
2007-12-20 19:11 ` Drew Adams
2007-12-20 19:27 ` Drew Adams
2007-12-21 3:59 ` Richard Stallman
2007-12-21 6:47 ` Drew Adams
2007-12-21 3:59 ` Richard Stallman
2007-12-21 6:48 ` Drew Adams
2007-12-21 9:36 ` Lennart Borgman (gmail)
2007-12-21 18:20 ` Drew Adams
2007-12-21 22:03 ` Drew Adams
2007-12-22 6:29 ` Richard Stallman
2007-12-22 20:58 ` Lennart Borgman (gmail) [this message]
2007-12-23 10:54 ` Per Abrahamsen
2007-12-23 12:46 ` Lennart Borgman (gmail)
2007-12-25 13:52 ` Per Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476D7A66.2080901@gmail.com \
--to=lennart.borgman@gmail.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=per.abrahamsen@gmail.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).