* vc-revision-other-window problem
@ 2007-12-17 1:06 Emanuele Giaquinta
2007-12-17 7:57 ` martin rudalics
0 siblings, 1 reply; 5+ messages in thread
From: Emanuele Giaquinta @ 2007-12-17 1:06 UTC (permalink / raw)
To: emacs-devel
Hi,
in latest cvs vc-revision-other-window hangs in vc-ensure-vc-buffer
when called for the second time. The problem seems to be the following
code in vc-ensure-vc-buffer
(while vc-parent-buffer
(set-buffer vc-parent-buffer))
the first time it is fine because vc-parent-buffer is nil, but, since
vc-revision-other-window calls vc-find-revision which sets
vc-parent-buffer, the second time vc-parent-buffer will have a non nil
value. Hope the diagnosis is correct.
Emanuele Giaquinta
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vc-revision-other-window problem
2007-12-17 1:06 vc-revision-other-window problem Emanuele Giaquinta
@ 2007-12-17 7:57 ` martin rudalics
2007-12-17 10:12 ` Emanuele Giaquinta
0 siblings, 1 reply; 5+ messages in thread
From: martin rudalics @ 2007-12-17 7:57 UTC (permalink / raw)
To: Emanuele Giaquinta; +Cc: emacs-devel
> in latest cvs vc-revision-other-window hangs in vc-ensure-vc-buffer
> when called for the second time. The problem seems to be the following
> code in vc-ensure-vc-buffer
>
> (while vc-parent-buffer
> (set-buffer vc-parent-buffer))
>
> the first time it is fine because vc-parent-buffer is nil, but, since
> vc-revision-other-window calls vc-find-revision which sets
> vc-parent-buffer, the second time vc-parent-buffer will have a non nil
> value. Hope the diagnosis is correct.
Does it work with the attached patch?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vc-revision-other-window problem
2007-12-17 7:57 ` martin rudalics
@ 2007-12-17 10:12 ` Emanuele Giaquinta
2007-12-17 10:23 ` martin rudalics
0 siblings, 1 reply; 5+ messages in thread
From: Emanuele Giaquinta @ 2007-12-17 10:12 UTC (permalink / raw)
To: martin rudalics; +Cc: emacs-devel
On Mon, Dec 17, 2007 at 08:57:35AM +0100, martin rudalics wrote:
>> in latest cvs vc-revision-other-window hangs in vc-ensure-vc-buffer
>> when called for the second time. The problem seems to be the following
>> code in vc-ensure-vc-buffer
>>
>> (while vc-parent-buffer
>> (set-buffer vc-parent-buffer))
>>
>> the first time it is fine because vc-parent-buffer is nil, but, since
>> vc-revision-other-window calls vc-find-revision which sets
>> vc-parent-buffer, the second time vc-parent-buffer will have a non nil
>> value. Hope the diagnosis is correct.
>
> Does it work with the attached patch?
Which patch? :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vc-revision-other-window problem
2007-12-17 10:12 ` Emanuele Giaquinta
@ 2007-12-17 10:23 ` martin rudalics
2007-12-17 10:38 ` Emanuele Giaquinta
0 siblings, 1 reply; 5+ messages in thread
From: martin rudalics @ 2007-12-17 10:23 UTC (permalink / raw)
To: Emanuele Giaquinta; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 72 bytes --]
>>Does it work with the attached patch?
>
>
> Which patch? :)
Sorry.
[-- Attachment #2: vc.patch --]
[-- Type: text/plain, Size: 844 bytes --]
*** vc.el.~1.491.~ Sat Dec 8 10:07:04 2007
--- vc.el Mon Dec 17 08:53:54 2007
***************
*** 1297,1303 ****
"Make sure that the current buffer visits a version-controlled file."
(if vc-dired-mode
(set-buffer (find-file-noselect (dired-get-filename)))
! (while vc-parent-buffer
(set-buffer vc-parent-buffer))
(if (not buffer-file-name)
(error "Buffer %s is not associated with a file" (buffer-name))
--- 1297,1304 ----
"Make sure that the current buffer visits a version-controlled file."
(if vc-dired-mode
(set-buffer (find-file-noselect (dired-get-filename)))
! (while (and vc-parent-buffer
! (not (eq vc-parent-buffer (current-buffer))))
(set-buffer vc-parent-buffer))
(if (not buffer-file-name)
(error "Buffer %s is not associated with a file" (buffer-name))
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vc-revision-other-window problem
2007-12-17 10:23 ` martin rudalics
@ 2007-12-17 10:38 ` Emanuele Giaquinta
0 siblings, 0 replies; 5+ messages in thread
From: Emanuele Giaquinta @ 2007-12-17 10:38 UTC (permalink / raw)
To: martin rudalics; +Cc: emacs-devel
On Mon, Dec 17, 2007 at 11:23:16AM +0100, martin rudalics wrote:
>>> Does it work with the attached patch?
>>
>>
>> Which patch? :)
>
> Sorry.
It works, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-12-17 10:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-17 1:06 vc-revision-other-window problem Emanuele Giaquinta
2007-12-17 7:57 ` martin rudalics
2007-12-17 10:12 ` Emanuele Giaquinta
2007-12-17 10:23 ` martin rudalics
2007-12-17 10:38 ` Emanuele Giaquinta
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).