From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Uninformative comment in files.el Date: Wed, 12 Dec 2007 10:17:23 +0100 Message-ID: <475FA723.9030607@gmx.at> References: <475EF93E.3060203@ig.com.br> <475F0992.2030307@gmx.at> <475F45EB.2070704@ig.com.br> <87mysg1l17.fsf@actcom.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1197451185 3664 80.91.229.12 (12 Dec 2007 09:19:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Dec 2007 09:19:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Yoni Rabkin Katzenell Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 12 10:19:56 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J2Nkx-0005vF-Cg for ged-emacs-devel@m.gmane.org; Wed, 12 Dec 2007 10:19:55 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2Nkf-0003Hv-2O for ged-emacs-devel@m.gmane.org; Wed, 12 Dec 2007 04:19:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2Nii-0002pu-Jn for emacs-devel@gnu.org; Wed, 12 Dec 2007 04:17:36 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2Nif-0002oF-30 for emacs-devel@gnu.org; Wed, 12 Dec 2007 04:17:34 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2Nie-0002nt-Ot for emacs-devel@gnu.org; Wed, 12 Dec 2007 04:17:32 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1J2Nie-0002At-AU for emacs-devel@gnu.org; Wed, 12 Dec 2007 04:17:32 -0500 Original-Received: (qmail invoked by alias); 12 Dec 2007 09:17:30 -0000 Original-Received: from N779P015.adsl.highway.telekom.at (EHLO [62.47.41.79]) [62.47.41.79] by mail.gmx.net (mp033) with SMTP; 12 Dec 2007 10:17:30 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/q61RSkTDq+7aaYlie9/u6r5mqKXfZOBcnjdLVOs 2kel6nP0IHtJjE User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <87mysg1l17.fsf@actcom.com> X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85086 Archived-At: > After reading that thread (which I neglected to do beforehand, sorry) Not your fault. The TODO item should have included a link to that thread. > I still think that revert-buffer should remove all overlays and the mark. I think your patch is correct but am not sure about a number of related issues. For example, is auto-reverting affected by your change and how? Is `remove-overlays' the right function to remove all overlays in a buffer or should we provide a simpler function that doesn't check overlay boundaries? Is `overlay-recenter' needed in this context? Shall we remove overlays stored in `permanent-local' variables? Finally we should look into the `kill-all-local-variables' issue raised by Kim. > My reasoning is based on the way revert-buffer is implemented, which is > to work for a simple default scenario, and to hand off any more complex > reverting to other modes via `revert-buffer-function', which replaces > revert-buffer's actions entirely if defined. For this reason, I don't > see any one fix which would solve the problem for all modes. In the particular case the problem was specific to a minor mode. It seems hardly feasible to make `revert-buffer-function' specific to minor modes.