From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vinicius Jose Latorre Newsgroups: gmane.emacs.devel Subject: Re: Uninformative comment in files.el Date: Tue, 11 Dec 2007 23:22:35 -0300 Message-ID: <475F45EB.2070704@ig.com.br> References: <475EF93E.3060203@ig.com.br> <475F0992.2030307@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1197422522 2104 80.91.229.12 (12 Dec 2007 01:22:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Dec 2007 01:22:02 +0000 (UTC) Cc: Stefan Monnier , "Richard M. Stallman" , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 12 02:22:10 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J2GIb-00075s-96 for ged-emacs-devel@m.gmane.org; Wed, 12 Dec 2007 02:22:09 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2GIJ-0007y9-7K for ged-emacs-devel@m.gmane.org; Tue, 11 Dec 2007 20:21:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2GIE-0007uU-U4 for emacs-devel@gnu.org; Tue, 11 Dec 2007 20:21:46 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2GIA-0007ks-D4 for emacs-devel@gnu.org; Tue, 11 Dec 2007 20:21:46 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2GIA-0007ke-9E for emacs-devel@gnu.org; Tue, 11 Dec 2007 20:21:42 -0500 Original-Received: from hs-out-0708.google.com ([64.233.178.250] helo=hs-out-2122.google.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J2GI9-0005dE-VY for emacs-devel@gnu.org; Tue, 11 Dec 2007 20:21:42 -0500 Original-Received: by hs-out-2122.google.com with SMTP id 55so35163hsc.10 for ; Tue, 11 Dec 2007 17:21:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; bh=7BL7TgHdweJw/VxY2B90THVlIzZX4lV8A89YRKASEjc=; b=hpQAWP0kjA0RTKfY1wP/VGRP+v/vX/2T0PcTpfyuIg1iXPGCTntbJ2+pChKav/HLdUHzmucsha7BHKATTWqihLNy+eheYEOGcRUAQ+7d8lPn0RcSrtSXNibn9fdHTUES+f4hOahXSv7t5xNGZXjYYkUcNow16sh14t9toREI95c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; b=bungvPwxp0pF+z4uVGzaVbcVPNdZl9IHSvQ+yhnaPNVeFCIe32czuscnZQoQDa4Ro3nWWFE2ZQ/9orVMXOQcxTk1AZh4pCzcJgeadQAN7bxNm282gkXAH7inJNBbAFYI2etPm2j+9AQXBaag6sxVzZZs91J8zxiI7JpjD42sU4A= Original-Received: by 10.70.14.20 with SMTP id 20mr142405wxn.25.1197422500892; Tue, 11 Dec 2007 17:21:40 -0800 (PST) Original-Received: from ?192.168.0.100? ( [201.82.14.165]) by mx.google.com with ESMTPS id h20sm1939294wxd.2007.12.11.17.21.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 11 Dec 2007 17:21:39 -0800 (PST) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7 In-Reply-To: <475F0992.2030307@gmx.at> X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 (Google crawlbot) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85073 Archived-At: martin rudalics wrote: >>> Could whoever installed the following change: >>> >>> 2007-12-10 Yoni Rabkin Katzenell (tiny >>> change) >>> * file.el (revert-buffer): Eliminate overlays and the mark. >>> >>> replace the comment "Reset the mark and remove all overlays" which just >>> paraphrases the code, with a comment that actually explains why we >>> want/need to do that? >>> >> >> >> This is not explained in etc/TODO file. >> >> The patch refers to this line in etc/TODO file: >> >> ** revert-buffer should eliminate overlays and the mark. >> >> >> Does anyone know why this is necessary? > > I'm afraid the patch installed is overly simplistic. You can find out > more by looking at the thread starting with > > http://lists.gnu.org/archive/html/emacs-devel/2005-11/msg01346.html > > For the moment I'd strongly propose to revert the change and study the > problem in more depth. Ok, I've read the thread. Indeed, the problem is not so simple. I've just undone the patch in CVS trunk.