From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Uninformative comment in files.el Date: Tue, 11 Dec 2007 23:05:06 +0100 Message-ID: <475F0992.2030307@gmx.at> References: <475EF93E.3060203@ig.com.br> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1197410748 442 80.91.229.12 (11 Dec 2007 22:05:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Dec 2007 22:05:48 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Vinicius Jose Latorre Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 11 23:05:55 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J2DEd-0005me-Bi for ged-emacs-devel@m.gmane.org; Tue, 11 Dec 2007 23:05:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2DEL-0006wT-F0 for ged-emacs-devel@m.gmane.org; Tue, 11 Dec 2007 17:05:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2DEH-0006u5-EA for emacs-devel@gnu.org; Tue, 11 Dec 2007 17:05:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2DEC-0006oh-He for emacs-devel@gnu.org; Tue, 11 Dec 2007 17:05:28 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2DEC-0006ob-A4 for emacs-devel@gnu.org; Tue, 11 Dec 2007 17:05:24 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1J2DEB-0002ug-S0 for emacs-devel@gnu.org; Tue, 11 Dec 2007 17:05:24 -0500 Original-Received: (qmail invoked by alias); 11 Dec 2007 22:05:22 -0000 Original-Received: from N832P009.adsl.highway.telekom.at (EHLO [62.47.47.233]) [62.47.47.233] by mail.gmx.net (mp058) with SMTP; 11 Dec 2007 23:05:22 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19imChbae9inL1pArqt2MvkxZZQK1glE4jrjLOCaZ ttc32I9RZUSkQK User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <475EF93E.3060203@ig.com.br> X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85067 Archived-At: >> Could whoever installed the following change: >> >> 2007-12-10 Yoni Rabkin Katzenell (tiny change) >> * file.el (revert-buffer): Eliminate overlays and the mark. >> >> replace the comment "Reset the mark and remove all overlays" which just >> paraphrases the code, with a comment that actually explains why we >> want/need to do that? >> > > > This is not explained in etc/TODO file. > > The patch refers to this line in etc/TODO file: > > ** revert-buffer should eliminate overlays and the mark. > > > Does anyone know why this is necessary? I'm afraid the patch installed is overly simplistic. You can find out more by looking at the thread starting with http://lists.gnu.org/archive/html/emacs-devel/2005-11/msg01346.html For the moment I'd strongly propose to revert the change and study the problem in more depth. > > > > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-devel >