unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: Why is not end-of-defun-function buffer local?
Date: Sun, 09 Dec 2007 02:45:11 +0100	[thread overview]
Message-ID: <475B48A7.2030509@gmail.com> (raw)
In-Reply-To: <jwvprxhdk10.fsf-monnier+emacs@gnu.org>

Stefan Monnier wrote:
>> Looking at some code that is a bit older it looks like some of it uses
>> make-local-variable where it is not needed since the variables in question
>> are always buffer local. From that I draw the conclusion that the code in
>> Emacs uses make-variable-buffer-local more often now. Is not that the case?
> 
> make-variable-buffer-local has the following downsides:
> 1 - it cannot be reverted.
> 2 - it may be done too late.
> 3 - when you see `setq' it's not obvious that the setting is buffer-local
>     unless you remember seeing the call to make-variable-buffer-local.
> The second problem may also explain what you're seeing: some code may
> set a variable before the make-variable-buffer-local gets run.
> It's actually "common" to introduce bugs this way, because people see
> "this is automatically buffer-local" in the C-h v info, so they just use
> `setq' without realizing that the setq may occur before the package
> gets loaded.
> make-variable-buffer-local is not evil, but make-local-variable is much
> tamer and more explicit, and it works just as well in most cases.


Thanks, that was a good explanation. Why not add this to the doc string 
of make-variable-buffer-local?

  reply	other threads:[~2007-12-09  1:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-08  1:02 Why is not end-of-defun-function buffer local? Lennart Borgman (gmail)
2007-12-08  2:18 ` Stefan Monnier
2007-12-08 18:04   ` Lennart Borgman (gmail)
2007-12-08 20:16     ` Stefan Monnier
2007-12-09  1:45       ` Lennart Borgman (gmail) [this message]
2007-12-09  2:45         ` Stefan Monnier
2007-12-09  3:04           ` Lennart Borgman (gmail)
2007-12-09 13:02           ` martin rudalics
2007-12-10  5:13             ` Stefan Monnier
2007-12-11 12:53               ` martin rudalics
2007-12-11 14:58                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475B48A7.2030509@gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).