From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.devel Subject: Re: Feature request: permanent-local values in hooks buffer local values Date: Tue, 04 Dec 2007 19:13:35 +0100 Message-ID: <475598CF.4050200@gmail.com> References: <475439BD.7070000@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1196792063 18822 80.91.229.12 (4 Dec 2007 18:14:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Dec 2007 18:14:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 04 19:14:30 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IzcHk-0005VP-Ka for ged-emacs-devel@m.gmane.org; Tue, 04 Dec 2007 19:14:20 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IzcHT-00072x-QW for ged-emacs-devel@m.gmane.org; Tue, 04 Dec 2007 13:14:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IzcHO-00070G-HK for emacs-devel@gnu.org; Tue, 04 Dec 2007 13:13:58 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IzcHM-0006y8-O6 for emacs-devel@gnu.org; Tue, 04 Dec 2007 13:13:57 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IzcHM-0006y0-Hb for emacs-devel@gnu.org; Tue, 04 Dec 2007 13:13:56 -0500 Original-Received: from ch-smtp01.sth.basefarm.net ([80.76.149.212]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IzcHI-0002HU-1U; Tue, 04 Dec 2007 13:13:52 -0500 Original-Received: from c83-254-148-228.bredband.comhem.se ([83.254.148.228]:61587 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1IzcH0-0002Xr-5o; Tue, 04 Dec 2007 19:13:37 +0100 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 In-Reply-To: X-Antivirus: avast! (VPS 071204-0, 2007-12-04), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.148.228 X-Scan-Result: No virus found in message 1IzcH0-0002Xr-5o. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1IzcH0-0002Xr-5o 67215fe3e65d5e0ba5408fec26ad5953 X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84662 Archived-At: Richard Stallman wrote: > For buffer local values of hooks you can perhaps use that, but it > probably does not do what you want. Some functions in a hook should > survive changing major mode (for the same reasons that variables should > do it), but other should not. > > Could somehow a feature be added to hooks that fulfills the need I have > sketched above? > > Isn't change-major-mode-hook sufficient to take care of this need? Perhaps you meant after-change-major-mode-hook? Yes, minor modes can add them selves to after-change-major-mode-hook to re-add their buffer local hook functions if that fits. Perhaps that is better. It could look something like below where I have used flymake as an example. (flymake-mode is a minor mode that is buffer local, but that does not really care about major mode. It depends on the buffer file name instead.): (put 'flymake-mode 'permanent-local t) (defun flymake-add-to-local-hooks () (when flymake-mode (add-hook 'after-change-functions 'flymake-after-change-function nil t) (add-hook 'after-save-hook 'flymake-after-save-hook nil t) (add-hook 'kill-buffer-hook 'flymake-kill-buffer-hook nil t))) (add-hook 'after-change-major-mode-hook 'flymake-add-to-local-hooks) What disturbs me about a solution like this is that the global value of after-change-major-mode-hook must be used. (Am I missing something there?) It does not mean any performance penalty, of course. It just that it feels a bit strange. Is this the way to go for such minor modes as flymake-mode? I think we need some guidelines here for minor mode authors. The reason I am asking this is mainly because it has to be solved in some way for mumamo-mode. (For those who do not know about it see http://www.emacswiki.org/cgi-bin/wiki/MuMaMo )