From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: lib-src/pop.c rev 1.42 broken if KERBEROS is enabled Date: Mon, 19 Nov 2007 12:10:20 +0100 Message-ID: <47416F1C.4090204@swipnet.se> References: <87wsseiks8.fsf@leeloo.anubex.internal> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1195470659 21927 80.91.229.12 (19 Nov 2007 11:10:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Nov 2007 11:10:59 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: Tim Van Holder Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 19 12:11:02 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Iu4Wi-0008Ts-4X for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2007 12:10:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iu4WU-0001L0-Gz for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2007 06:10:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iu4WR-0001JC-LT for emacs-devel@gnu.org; Mon, 19 Nov 2007 06:10:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Iu4WQ-0001HT-U4 for emacs-devel@gnu.org; Mon, 19 Nov 2007 06:10:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iu4WQ-0001HG-QF for emacs-devel@gnu.org; Mon, 19 Nov 2007 06:10:34 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Iu4WQ-00011A-Jb for emacs-devel@gnu.org; Mon, 19 Nov 2007 06:10:34 -0500 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Iu4WQ-0004ck-CK for emacs-pretest-bug@gnu.org; Mon, 19 Nov 2007 06:10:34 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Iu4WN-00010o-RM for emacs-pretest-bug@gnu.org; Mon, 19 Nov 2007 06:10:34 -0500 Original-Received: from av8-2-sn3.vrr.skanova.net ([81.228.9.184]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Iu4WN-00010Z-Ej for emacs-pretest-bug@gnu.org; Mon, 19 Nov 2007 06:10:31 -0500 Original-Received: by av8-2-sn3.vrr.skanova.net (Postfix, from userid 502) id 7B06437EB4; Mon, 19 Nov 2007 12:10:30 +0100 (CET) Original-Received: from smtp3-1-sn3.vrr.skanova.net (smtp3-1-sn3.vrr.skanova.net [81.228.9.101]) by av8-2-sn3.vrr.skanova.net (Postfix) with ESMTP id 0876E37EB4; Mon, 19 Nov 2007 12:10:28 +0100 (CET) Original-Received: from husetbladh.homeip.net (90-231-102-24-no59.tbcn.telia.com [90.231.102.24]) by smtp3-1-sn3.vrr.skanova.net (Postfix) with ESMTP id A872437E4F; Mon, 19 Nov 2007 12:10:28 +0100 (CET) User-Agent: Thunderbird 2.0.0.9 (X11/20071031) In-Reply-To: <87wsseiks8.fsf@leeloo.anubex.internal> X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83635 gmane.emacs.pretest.bugs:20313 Archived-At: Tim Van Holder skrev: > lib-src/pop.c does not currently build for me; the changes to add getaddrinfo support break compilation if kerberos is enabled. > > There are two problems, both on line 1178: > - 'realhost' is used, but that variable is only defined for !KERBEROS5 > -> easily fixed by moving it out of the KERBEROS5 conditional > - 'hostent' is used, but is only available (and filled) if !HAVE_GETADDRINFO > -> Kerberos code needs to have conditional code introduced for HAVE_GETADDRINFO > Sorry about that, I've checked in a fix. Please try it. Jan D.