From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [patch] proposal tiny cleanup for window code Date: Wed, 07 Nov 2007 13:57:01 +0100 Message-ID: <4731B61D.7040106@gmx.at> References: <47319A3B.7030200@yandex.ru> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1194440172 16703 80.91.229.12 (7 Nov 2007 12:56:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Nov 2007 12:56:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 07 13:56:16 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IpkS7-0006Ch-GU for ged-emacs-devel@m.gmane.org; Wed, 07 Nov 2007 13:56:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IpkRw-00038B-CA for ged-emacs-devel@m.gmane.org; Wed, 07 Nov 2007 07:56:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IpkRt-000386-Vm for emacs-devel@gnu.org; Wed, 07 Nov 2007 07:56:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IpkRr-00037u-Jp for emacs-devel@gnu.org; Wed, 07 Nov 2007 07:56:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IpkRr-00037r-Ek for emacs-devel@gnu.org; Wed, 07 Nov 2007 07:55:59 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1IpkRq-0002Oq-Si for emacs-devel@gnu.org; Wed, 07 Nov 2007 07:55:59 -0500 Original-Received: (qmail invoked by alias); 07 Nov 2007 12:55:57 -0000 Original-Received: from N912P020.adsl.highway.telekom.at (EHLO [62.47.57.244]) [62.47.57.244] by mail.gmx.net (mp049) with SMTP; 07 Nov 2007 13:55:57 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+hAxo4IAmhyyY64Z4WYrP9imVMuH44100lABgZjl H8QOWFODwKgYew User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <47319A3B.7030200@yandex.ru> X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82729 Archived-At: > I've found that too_small_ok member of struct window isn't used anywhere > except size_window, > so it looks like there are no reasons to have too_small_ok within struct > window... I fail to understand the use of that but the current code reads as if (old_size < min_size && nodelete_p != 2) w->too_small_ok = Qt; /* Move the following test here since otherwise the preceding test doesn't make sense. martin. */ if (nodelete_p == 2) nodelete_p = 0; /* Maybe delete WINDOW if it's too small. */ if (nodelete_p != 1 && !NILP (w->parent)) { if (!MINI_WINDOW_P (w) && !NILP (w->too_small_ok)) hence too_small_ok is never set to t when nodelete_p initially equals 2. With your change this becomes /* Move the following test here since otherwise the preceding test doesn't make sense. martin. */ if (nodelete_p == 2) nodelete_p = 0; /* Maybe delete WINDOW if it's too small. */ if (nodelete_p != 1 && !NILP (w->parent)) { if (!MINI_WINDOW_P (w) && old_size < min_size && nodelete_p != 2) hence (the "implied") too_small_ok can be set to t when nodelete_p initially equals 2 and your version is not semantically equivalent to the previous one. Please verify again.