From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vinicius Jose Latorre Newsgroups: gmane.emacs.devel Subject: Re: finish version test cleanup: Lucid Date: Sun, 28 Oct 2007 17:11:11 -0300 Message-ID: <4724ECDF.3080806@ig.com.br> References: <200710281747.l9SHlHL1026263@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1193598439 22456 80.91.229.12 (28 Oct 2007 19:07:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Oct 2007 19:07:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 28 20:07:21 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ImDTe-0003IH-FN for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2007 20:07:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImDTV-0001GU-6z for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2007 15:07:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImDSw-0000t8-LE for emacs-devel@gnu.org; Sun, 28 Oct 2007 15:06:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImDSv-0000qj-13 for emacs-devel@gnu.org; Sun, 28 Oct 2007 15:06:30 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImDSu-0000qV-RU for emacs-devel@gnu.org; Sun, 28 Oct 2007 15:06:28 -0400 Original-Received: from an-out-0708.google.com ([209.85.132.251]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImDSu-0007o1-Fr for emacs-devel@gnu.org; Sun, 28 Oct 2007 15:06:28 -0400 Original-Received: by an-out-0708.google.com with SMTP id c38so169704ana for ; Sun, 28 Oct 2007 12:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; bh=7aEegYuCheTz/52vz/Fy24X1+aJsK7RNYyE3xEpQFYg=; b=ewQcgCYKxOgT02t68tveY4OIBOQGnLJZUrH744lqRtsgF7lw/XT2nx33D7MqmLSaIIR309gDZUIpqy4b8oMhvDX8BuwXWFe6B2sQMglGDVACXmUTeVURmOzeocK6zr9Rp9PI3EH9667QlDx1jrBS8DZnQx6KRUyvX3JpdZ3ieq8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; b=jHOnGbWGUnjTPAroA8nwMjuawjd7A+7uTMSStVUfH3dcjYe1vGD+NTwck652QNhZj8bcENRpYe64HVndahNfya92eOnmw6bctclup+c2pyfELbY/XJlQeqLscedJhqxJUnjQoLVW4BGlH/Gm+FWieQY5LMj2ESrciBsPY/QNgLs= Original-Received: by 10.100.210.9 with SMTP id i9mr209161ang.1193598387535; Sun, 28 Oct 2007 12:06:27 -0700 (PDT) Original-Received: from ?192.168.0.100? ( [201.82.40.223]) by mx.google.com with ESMTPS id d36sm5479465and.2007.10.28.12.06.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 28 Oct 2007 12:06:25 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071009 SeaMonkey/1.1.5 In-Reply-To: <200710281747.l9SHlHL1026263@oogie-boogie.ics.uci.edu> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81985 Archived-At: Dan Nicolaescu wrote: > Most string version tests have been replaced with feature tests. > These are the remaining ones: > > ./progmodes/cperl-mode.el:81: (defconst cperl-xemacs-p (string-match "XEmacs\\|Lucid" emacs-version)) > ./progmodes/cperl-mode.el:154:(defconst cperl-xemacs-p (string-match "XEmacs\\|Lucid" emacs-version)) > ./ielm.el:172: (if (string-match "Lucid" emacs-version) > ./ps-print.el:1467: ((string-match "Lucid" emacs-version) > ./ps-print.el:1469: ((string-match "Epoch" emacs-version) > ./calc/calc.el:825:(defvar calc-emacs-type-lucid (not (not (string-match "Lucid" emacs-version)))) > ./emulation/tpu-mapper.el:83:(defconst tpu-lucid-emacs19-p (string-match "Lucid" emacs-version) > > Can these tests be replaced with feature tests? > AFAIK, there isn't any feature test for Lucid and Epoch. Can these tests be eliminated?