From: Vinicius Jose Latorre <viniciusjl@ig.com.br>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: finish version test cleanup: Lucid
Date: Sun, 28 Oct 2007 17:11:11 -0300 [thread overview]
Message-ID: <4724ECDF.3080806@ig.com.br> (raw)
In-Reply-To: <200710281747.l9SHlHL1026263@oogie-boogie.ics.uci.edu>
Dan Nicolaescu wrote:
> Most string version tests have been replaced with feature tests.
> These are the remaining ones:
>
> ./progmodes/cperl-mode.el:81: (defconst cperl-xemacs-p (string-match "XEmacs\\|Lucid" emacs-version))
> ./progmodes/cperl-mode.el:154:(defconst cperl-xemacs-p (string-match "XEmacs\\|Lucid" emacs-version))
> ./ielm.el:172: (if (string-match "Lucid" emacs-version)
> ./ps-print.el:1467: ((string-match "Lucid" emacs-version)
> ./ps-print.el:1469: ((string-match "Epoch" emacs-version)
> ./calc/calc.el:825:(defvar calc-emacs-type-lucid (not (not (string-match "Lucid" emacs-version))))
> ./emulation/tpu-mapper.el:83:(defconst tpu-lucid-emacs19-p (string-match "Lucid" emacs-version)
>
> Can these tests be replaced with feature tests?
>
AFAIK, there isn't any feature test for Lucid and Epoch.
Can these tests be eliminated?
next prev parent reply other threads:[~2007-10-28 20:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 17:47 finish version test cleanup: Lucid Dan Nicolaescu
2007-10-28 20:11 ` Vinicius Jose Latorre [this message]
2007-10-29 0:10 ` Glenn Morris
2007-10-29 0:34 ` Jay Belanger
2007-10-29 0:45 ` Dan Nicolaescu
2007-10-29 5:35 ` Jay Belanger
2007-10-29 8:59 ` David Kastrup
2007-10-29 12:25 ` Jay Belanger
2007-10-29 9:21 ` Richard Stallman
2007-10-29 17:30 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4724ECDF.3080806@ig.com.br \
--to=viniciusjl@ig.com.br \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).