From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: JSON/YAML/TOML/etc. parsing performance Date: Tue, 3 Oct 2017 23:41:41 -0700 Organization: UCLA Computer Science Department Message-ID: <472176ce-846b-1f24-716b-98eb95ceaa47@cs.ucla.edu> References: <87poaqhc63.fsf@lifelogs.com> <8360ceh5f1.fsf@gnu.org> <83h8vl5lf9.fsf@gnu.org> <83r2um3fqi.fsf@gnu.org> <43520b71-9e25-926c-d744-78098dad6441@cs.ucla.edu> <83o9pnzddc.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1507099368 18327 195.159.176.226 (4 Oct 2017 06:42:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Oct 2017 06:42:48 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 Cc: p.stephani2@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 04 08:42:44 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzdOF-0004D4-SG for ged-emacs-devel@m.gmane.org; Wed, 04 Oct 2017 08:42:43 +0200 Original-Received: from localhost ([::1]:33405 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzdON-0001UG-00 for ged-emacs-devel@m.gmane.org; Wed, 04 Oct 2017 02:42:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzdNM-0001Q7-JZ for emacs-devel@gnu.org; Wed, 04 Oct 2017 02:41:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzdNL-0005G1-Ux for emacs-devel@gnu.org; Wed, 04 Oct 2017 02:41:48 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43394) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dzdNI-0005BE-AR; Wed, 04 Oct 2017 02:41:44 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 33186160D12; Tue, 3 Oct 2017 23:41:43 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rCODpLPGFVDC; Tue, 3 Oct 2017 23:41:42 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EFE3E160E1A; Tue, 3 Oct 2017 23:41:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id aioU6uQ7EE3i; Tue, 3 Oct 2017 23:41:41 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.18.85]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A7D27160D12; Tue, 3 Oct 2017 23:41:41 -0700 (PDT) In-Reply-To: <83o9pnzddc.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219063 Archived-At: Eli Zaretskii wrote: > I'd prefer to have such tests inside 'insert' and its subroutines, or > to tweak the argument passed to 'insert' to have the existing checks > catch the problem. Can we do that, please? It doesn't feel right to > me to have this kind of checks in application C code. There is no universal C integer type, so this doesn't sound doable in general. Even intmax_t is not wide enough, as it doesn't subsume uintmax_t. And I wouldn't want APIs to switch to intmax_t or uintmax_t merely because some library's types don't match ours; the responsibility for passing arguments correctly and for checking for any out-of-range values belongs to the glue code, not to Emacs internals.