[aaronh@garden.org: patch: Tutorial position not saved]

[aaronh@garden.org: patch: Tutorial position not saved]

[Richard Stallman]

Would someone please install this and ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
	autolearn=failed version=3.1.0
Date: Tue, 16 Oct 2007 10:31:30 -0400
To: bug-gnu-emacs@gnu.org
From: Aaron Hawley <aaronh@garden.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Subject: patch: Tutorial position not saved

When you kill the TUTORIAL buffer, Emacs asks: "Save your position
in the tutorial? (y or n)".  When you hit "n" for no, that question
lingers in the minibuffer.  It seemed awkward to be hanging around; unlike
how Emacs usually behaves.

One solution, is to report a message to the user that the position wasn't
saved.  This clears the minibuffer of the question.

- --- orig/lisp/tutorial.el
+++ mod/lisp/tutorial.el
@@ -656,7 +656,8 @@
   ;; This runs in a hook so protect it:
   (condition-case err
       (if (y-or-n-p "Save your position in the tutorial? ")
- -	  (tutorial--save-tutorial-to (tutorial--saved-file)))
+          (tutorial--save-tutorial-to (tutorial--saved-file))
+        (message "Tutorial position not saved"))
     (error (message "Error saving tutorial state: %s"
 		    (error-message-string err)))))
 


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/22.1/etc/DEBUG for instructions.


In GNU Emacs 22.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.10.8)
 of 2007-06-26 on xenbuilder4.fedora.phx.redhat.com
Windowing system distributor `The X.Org Foundation', version 11.0.70101000
configured using `configure  '--build=i386-redhat-linux-gnu'
'--host=i386-redhat-linux-gnu' '--target=i386-redhat-linux-gnu'
'--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin'
'--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share'
'--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec'
'--localstatedir=/var' '--sharedstatedir=/usr/com' '--mandir=/usr/share/man'
'--infodir=/usr/share/info' '--with-pop' '--with-sound' '--with-gtk'
'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu'
'target_alias=i386-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF
- -DSYSTEM_PURESIZE_EXTRA=16777216 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
- -fexceptions --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
- -fasynchronous-unwind-tables''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Diff

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
M-f M-b C-SPC M-f M-f M-f M-f M-f M-f M-f C-f M-w <help-echo> 
<help-echo> <help-echo> <help-echo> C-s s o u r c e 
1 9 C-s C-s C-a C-s C-s C-s C-a C-x C-f e m a c s . 
d e s k <tab> <return> C-x k <return> < C-_ < C-_ ESC 
< M-> M-< M-> M-v M-v M-v M-v M-v M-v M-v M-v M-v M-v 
M-v M-v M-v M-v M-v M-v M-v M-v M-v M-v M-v M-v M-v 
M-v M-v M-v M-v M-v M-v M-v C-v C-v C-v C-v C-v M-v 
C-n C-n C-n C-v C-v M-v <down-mouse-1> <mouse-1> <double-down-mouse-1> 
<double-mouse-1> M-w C-x C-f ~ / g n u / e m a c s 
/ l i s p / u t <backspace> <backspace> t u t o i <backspace> 
r i <tab> <return> C-x v <backspace> C-g C-g C-x v 
= C-x o C-x 1 C-h t q C-_ C-x k <return> n C-x b <return> 
C-n C-n C-n C-n C-n C-n C-n C-h e C-p C-e n C-a C-k 
C-_ C-x b <return> C-x 4 a C-y M-b M-b M-b M-b M-b 
M-b M-b M-b M-b M-b C-x o C-n C-e M-b M-b M-b M-b C-SPC 
C-e C-b C-b C-b M-w C-x o F <backspace> R e o r <backspace> 
<backspace> p o r t SPC " C-y " C-k M-q C-p C-e C-f 
C-p C-p C-p C-p C-e M-b M-b C-SPC C-e C-b C-w g a r 
d e n . o r g C-f C-f C-n C-n C-e C-p C-e M-b p o s 
i t i o n M-d M-q C-x o C-p C-n M-b M-b M-b M-d p o 
s i t i o n C-e C-r TAB C-g M-x r e p o r SPC e m <tab> 
<return>

Recent messages:
Running tla in the background... done
Loading tutorial...done
Preparing tutorial ...
Undo!

undo-start: No undo information in this buffer
Mark set [4 times]
Auto-saving...done
Quit
Loading emacsbug...done

- -- 
 National Gardening Association
 1100 Dorset Street, South Burlington, VT 05403 
 Email: support@garden.org - Web: www.garden.org/
- --
------- End of forwarded message -------

Re: [aaronh@garden.org: patch: Tutorial position not saved]

[Vinicius Jose Latorre]

Richard Stallman wrote:
> Would someone please install this and ack?
>   

Done in Emacs CVS trunk and EMACS 22 BRANCH.


> ------- Start of forwarded message -------
> X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY 
> 	autolearn=failed version=3.1.0
> Date: Tue, 16 Oct 2007 10:31:30 -0400
> To: bug-gnu-emacs@gnu.org
> From: Aaron Hawley <aaronh@garden.org>
> MIME-Version: 1.0
> Content-Type: text/plain; charset="iso-8859-1"
> Subject: patch: Tutorial position not saved
>
> When you kill the TUTORIAL buffer, Emacs asks: "Save your position
> in the tutorial? (y or n)".  When you hit "n" for no, that question
> lingers in the minibuffer.  It seemed awkward to be hanging around; unlike
> how Emacs usually behaves.
>
> One solution, is to report a message to the user that the position wasn't
> saved.  This clears the minibuffer of the question.
>
> - --- orig/lisp/tutorial.el
> +++ mod/lisp/tutorial.el
> @@ -656,7 +656,8 @@
>    ;; This runs in a hook so protect it:
>    (condition-case err
>        (if (y-or-n-p "Save your position in the tutorial? ")
> - -	  (tutorial--save-tutorial-to (tutorial--saved-file)))
> +          (tutorial--save-tutorial-to (tutorial--saved-file))
> +        (message "Tutorial position not saved"))
>      (error (message "Error saving tutorial state: %s"
>  		    (error-message-string err)))))
>  
>
>
> If Emacs crashed, and you have the Emacs process in the gdb debugger,
> please include the output from the following gdb commands:
>     `bt full' and `xbacktrace'.
> If you would like to further debug the crash, please read the file
> /usr/share/emacs/22.1/etc/DEBUG for instructions.
>
>
> In GNU Emacs 22.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.10.8)
>  of 2007-06-26 on xenbuilder4.fedora.phx.redhat.com
> Windowing system distributor `The X.Org Foundation', version 11.0.70101000
> configured using `configure  '--build=i386-redhat-linux-gnu'
> '--host=i386-redhat-linux-gnu' '--target=i386-redhat-linux-gnu'
> '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin'
> '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share'
> '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec'
> '--localstatedir=/var' '--sharedstatedir=/usr/com' '--mandir=/usr/share/man'
> '--infodir=/usr/share/info' '--with-pop' '--with-sound' '--with-gtk'
> 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu'
> 'target_alias=i386-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF
> - -DSYSTEM_PURESIZE_EXTRA=16777216 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
> - -fexceptions --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
> - -fasynchronous-unwind-tables''
>
> Important settings:
>   value of $LC_ALL: nil
>   value of $LC_COLLATE: nil
>   value of $LC_CTYPE: nil
>   value of $LC_MESSAGES: nil
>   value of $LC_MONETARY: nil
>   value of $LC_NUMERIC: nil
>   value of $LC_TIME: nil
>   value of $LANG: en_US.UTF-8
>   locale-coding-system: utf-8
>   default-enable-multibyte-characters: t
>
> Major mode: Diff
>
> Minor modes in effect:
>   shell-dirtrack-mode: t
>   tooltip-mode: t
>   tool-bar-mode: t
>   mouse-wheel-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   unify-8859-on-encoding-mode: t
>   utf-translate-cjk-mode: t
>   auto-compression-mode: t
>   line-number-mode: t
>
> Recent input:
> M-f M-b C-SPC M-f M-f M-f M-f M-f M-f M-f C-f M-w <help-echo> 
> <help-echo> <help-echo> <help-echo> C-s s o u r c e 
> 1 9 C-s C-s C-a C-s C-s C-s C-a C-x C-f e m a c s . 
> d e s k <tab> <return> C-x k <return> < C-_ < C-_ ESC 
> < M-> M-< M-> M-v M-v M-v M-v M-v M-v M-v M-v M-v M-v 
> M-v M-v M-v M-v M-v M-v M-v M-v M-v M-v M-v M-v M-v 
> M-v M-v M-v M-v M-v M-v M-v C-v C-v C-v C-v C-v M-v 
> C-n C-n C-n C-v C-v M-v <down-mouse-1> <mouse-1> <double-down-mouse-1> 
> <double-mouse-1> M-w C-x C-f ~ / g n u / e m a c s 
> / l i s p / u t <backspace> <backspace> t u t o i <backspace> 
> r i <tab> <return> C-x v <backspace> C-g C-g C-x v 
> = C-x o C-x 1 C-h t q C-_ C-x k <return> n C-x b <return> 
> C-n C-n C-n C-n C-n C-n C-n C-h e C-p C-e n C-a C-k 
> C-_ C-x b <return> C-x 4 a C-y M-b M-b M-b M-b M-b 
> M-b M-b M-b M-b M-b C-x o C-n C-e M-b M-b M-b M-b C-SPC 
> C-e C-b C-b C-b M-w C-x o F <backspace> R e o r <backspace> 
> <backspace> p o r t SPC " C-y " C-k M-q C-p C-e C-f 
> C-p C-p C-p C-p C-e M-b M-b C-SPC C-e C-b C-w g a r 
> d e n . o r g C-f C-f C-n C-n C-e C-p C-e M-b p o s 
> i t i o n M-d M-q C-x o C-p C-n M-b M-b M-b M-d p o 
> s i t i o n C-e C-r TAB C-g M-x r e p o r SPC e m <tab> 
> <return>
>
> Recent messages:
> Running tla in the background... done
> Loading tutorial...done
> Preparing tutorial ...
> Undo!
>
> undo-start: No undo information in this buffer
> Mark set [4 times]
> Auto-saving...done
> Quit
> Loading emacsbug...done
>
> - -- 
>  National Gardening Association
>  1100 Dorset Street, South Burlington, VT 05403 
>  Email: support@garden.org - Web: www.garden.org/
> - --
> ------- End of forwarded message -------
>