From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.0; Nonsense in lisp/frame.el after cvs-update Date: Sun, 14 Oct 2007 14:45:20 +0100 Message-ID: <47121D70.30508@gnu.org> References: <611E80D2-5CF7-4834-8843-DD3673E9514F@Web.DE> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1192369738 18812 80.91.229.12 (14 Oct 2007 13:48:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Oct 2007 13:48:58 +0000 (UTC) Cc: Peter Dyballa , emacs-pretest-bug@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 14 15:48:48 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ih3pg-0004SD-2C for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2007 15:48:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ih3pU-0005FW-DM for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2007 09:48:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ih3pQ-0005F9-7T for emacs-devel@gnu.org; Sun, 14 Oct 2007 09:48:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ih3pK-0005DB-U8 for emacs-devel@gnu.org; Sun, 14 Oct 2007 09:48:23 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ih3pK-0005D8-Q1 for emacs-devel@gnu.org; Sun, 14 Oct 2007 09:48:18 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ih3pK-0004Cl-7k for emacs-devel@gnu.org; Sun, 14 Oct 2007 09:48:18 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ih3oi-0000L6-7H for emacs-pretest-bug@gnu.org; Sun, 14 Oct 2007 09:48:10 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ih3n7-0003rf-B7 for emacs-pretest-bug@gnu.org; Sun, 14 Oct 2007 09:46:11 -0400 Original-Received: from outmail1.freedom2surf.net ([194.106.33.237]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ih3my-0003q7-Nw for emacs-pretest-bug@gnu.org; Sun, 14 Oct 2007 09:46:01 -0400 Original-Received: from [127.0.0.1] (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail1.freedom2surf.net (Postfix) with ESMTP id 3402A51E31; Sun, 14 Oct 2007 14:45:25 +0100 (BST) User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) In-Reply-To: X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80843 gmane.emacs.pretest.bugs:20127 Archived-At: Stefan Monnier wrote: >> (cond ((memq window-system '(x mac)) >> (x-focus-frame frame)) >> ((eq window-system 'w32) >> (w32-focus-frame frame)) >> ((eq window-system 'ns) >> (ns-focus-frame frame))) >> > > Can we fix this nonsense? Let's define internal-focus-frame which depending > on the return value of `framep' will dispatch to the various > display backends. We could even start with an elisp implementation of it. > What is the ns window system? On w32 that function was renamed to x-focus-frame a few weeks back, probably the wrong version was given priority during the merge. Generally if the function takes the same arguments, returns the same value and does the same thing, having a different name for different window systems' implementations just gets in the way.