From: Jason Rumney <jasonr@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Peter Dyballa <Peter_Dyballa@Web.DE>, emacs-pretest-bug@gnu.org
Subject: Re: 23.0.0; Nonsense in lisp/frame.el after cvs-update
Date: Sun, 14 Oct 2007 14:45:20 +0100 [thread overview]
Message-ID: <47121D70.30508@gnu.org> (raw)
In-Reply-To: <jwv1wby4fqe.fsf-monnier+emacs@gnu.org>
Stefan Monnier wrote:
>> (cond ((memq window-system '(x mac))
>> (x-focus-frame frame))
>> ((eq window-system 'w32)
>> (w32-focus-frame frame))
>> ((eq window-system 'ns)
>> (ns-focus-frame frame)))
>>
>
> Can we fix this nonsense? Let's define internal-focus-frame which depending
> on the return value of `framep' will dispatch to the various
> display backends. We could even start with an elisp implementation of it.
>
What is the ns window system? On w32 that function was renamed to
x-focus-frame a few weeks back, probably the wrong version was given
priority during the merge. Generally if the function takes the same
arguments, returns the same value and does the same thing, having a
different name for different window systems' implementations just gets
in the way.
next prev parent reply other threads:[~2007-10-14 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-13 11:12 23.0.0; Nonsense in lisp/frame.el after cvs-update Peter Dyballa
2007-10-13 12:15 ` martin rudalics
2007-10-14 2:02 ` Stefan Monnier
2007-10-14 13:45 ` Jason Rumney [this message]
2007-10-14 2:03 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2007-10-13 21:24 Peter Dyballa
2007-10-13 22:01 Peter Dyballa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47121D70.30508@gnu.org \
--to=jasonr@gnu.org \
--cc=Peter_Dyballa@Web.DE \
--cc=emacs-pretest-bug@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).