Re: 22.1.1; Frame title no more updated after calling `set-frame-configuration'

From: martin rudalics <rudalics@gmx.at>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: 22.1.1; Frame title no more updated after calling `set-frame-configuration'
Date: Mon, 08 Oct 2007 11:31:51 +0200	[thread overview]
Message-ID: <4709F907.6030909@gmx.at> (raw)
In-Reply-To: <hrabrzgmhl.fsf@fencepost.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

>>Could you try the patch below (against EMACS_22_BASE)?
> 
> 
> After applying this,
> 
> emacs -Q --eval '(set-frame-configuration (current-frame-configuration))'
> 
> segfaults in x_set_frame_parameters.

Glenn.  Could you try again with the attached Emacs_22_BASE patch?

[-- Attachment #2: frame-frame.patch --]
[-- Type: text/plain, Size: 2040 bytes --]

*** frame.c.~1.340.2.2.~	Sat Oct  6 11:46:22 2007
--- frame.c	Mon Oct  8 11:22:54 2007
***************
*** 100,105 ****
--- 100,106 ----
  #endif
  Lisp_Object Qparent_id;
  Lisp_Object Qtitle, Qname;
+ Lisp_Object Qexplicit_name;
  Lisp_Object Qunsplittable;
  Lisp_Object Qmenu_bar_lines, Qtool_bar_lines;
  Lisp_Object Qleft_fringe, Qright_fringe;
***************
*** 3006,3011 ****
--- 3007,3013 ----
      tem = Qnil;
    else
      XSETFASTINT (tem, FRAME_X_OUTPUT (f)->parent_desc);
+   store_in_alist (alistptr, Qexplicit_name, (f->explicit_name ? Qt : Qnil));
    store_in_alist (alistptr, Qparent_id, tem);
  }

***************
*** 3967,3972 ****
--- 3969,3976 ----
    staticpro (&Qframep);
    Qframe_live_p = intern ("frame-live-p");
    staticpro (&Qframe_live_p);
+   Qexplicit_name = intern ("explicit-name");
+   staticpro (&Qexplicit_name);
    Qheight = intern ("height");
    staticpro (&Qheight);
    Qicon = intern ("icon");

*** frame.el.~1.243.2.5.~	Sat Oct  6 11:05:52 2007
--- frame.el	Mon Oct  8 11:27:14 2007
***************
*** 807,814 ****
  			;; Since we can't set a frame's minibuffer status,
  			;; we might as well omit the parameter altogether.
  			(let* ((parms (nth 1 parameters))
! 			       (mini (assq 'minibuffer parms)))
! 			  (if mini (setq parms (delq mini parms)))
  			  parms))
  		       (set-window-configuration (nth 2 parameters)))
  		   (setq frames-to-delete (cons frame frames-to-delete))))))
--- 807,818 ----
  			;; Since we can't set a frame's minibuffer status,
  			;; we might as well omit the parameter altogether.
  			(let* ((parms (nth 1 parameters))
! 			       (mini (assq 'minibuffer parms))
! 			       (name (assq 'name parms))
! 			       (explicit-name (cdr (assq 'explicit-name parms))))
! 			  (when mini (setq parms (delq mini parms)))
! 			  (when (and name (not explicit-name))
! 			    (setq parms (delq name parms)))
  			  parms))
  		       (set-window-configuration (nth 2 parameters)))
  		   (setq frames-to-delete (cons frame frames-to-delete))))))

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel