From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50 compile problem on Windows XP Date: Fri, 05 Oct 2007 09:11:03 +0100 Message-ID: <4705F197.7020909@gnu.org> References: <47035169.8070402@gnu.org> <4703869F.6070909@gnu.org> <47038922.10105@gnu.org> <4705652C.5070803@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1191571888 27548 80.91.229.12 (5 Oct 2007 08:11:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 5 Oct 2007 08:11:28 +0000 (UTC) Cc: sridhar_ml@yahoo.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 05 10:11:25 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IdiHN-0004PE-64 for ged-emacs-devel@m.gmane.org; Fri, 05 Oct 2007 10:11:25 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdiHI-0002pf-8e for ged-emacs-devel@m.gmane.org; Fri, 05 Oct 2007 04:11:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IdiHE-0002nE-N1 for emacs-devel@gnu.org; Fri, 05 Oct 2007 04:11:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IdiHD-0002k8-Ie for emacs-devel@gnu.org; Fri, 05 Oct 2007 04:11:16 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdiHD-0002jm-Ci for emacs-devel@gnu.org; Fri, 05 Oct 2007 04:11:15 -0400 Original-Received: from outmail1.freedom2surf.net ([194.106.33.237]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IdiH9-0008Vn-CW; Fri, 05 Oct 2007 04:11:11 -0400 Original-Received: from [127.0.0.1] (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail1.freedom2surf.net (Postfix) with ESMTP id B3C8F50BFB; Fri, 5 Oct 2007 09:11:05 +0100 (BST) User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) In-Reply-To: X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80274 Archived-At: Eli Zaretskii wrote: >> Date: Thu, 04 Oct 2007 23:11:56 +0100 >> From: Jason Rumney >> Cc: emacs-devel@gnu.org >> >> I think it is better to remove this definition from lisp.h and include >> stdlib.h in the files that need it. >> > > Are you assuming that stdlib.h defines `abs' as a macro? If so, can > you tell why this assumption is valid? If not, how would including > stdlib.h help with this problem? > No, stdlib.h includes it as a function declaration. In the general case, the abs macro is dangerous, as it evaluates its argument twice. Is it really an important optimization to use a macro for this?