From: Jason Rumney <jasonr@gnu.org>
To: dhruva <dhruvakm@gmail.com>
Cc: Glenn Morris <rgm@gnu.org>, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [andrew.maguire@ge.com: Emacs 22.1 hung after delete-process]
Date: Fri, 17 Aug 2007 21:40:19 +0100 [thread overview]
Message-ID: <46C607B3.7060809@gnu.org> (raw)
In-Reply-To: <e3f230850708171031l162b4b3x83e81332c2f70af8@mail.gmail.com>
dhruva wrote:
> I have not modified the the call to WaitForSingleObject in the latest
> patch. I doubt the implementation of read which could be different for
> different compilers (C-runtime library).
>
It may be implemented as a macro in one or both compilers, that would
explain it. The C runtime library is the same system library in both
cases (CRTDLL.DLL)
> It is the call to read in _sys_read_ahead which continues to block
> even after the sub process is killed. If we change that read to use
> ReadFile using OVERLAPPED structure, we could handle canceling of IO
> when we want to terminate the thread more elegantly. But, that would
> be more changes as we need to use the HANDLE and not fd.
>
This would be a good change, not just here, but in sys_select in
w32proc.c, which is overcomplicated due to a past design decision to use
winsock 1.1 rather than winsock 2. We have changed that in 22.1 since
the versions of Windows NT that lack winsock 2 support have not been
supported by Emacs for some years now.
next prev parent reply other threads:[~2007-08-17 20:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 18:21 [andrew.maguire@ge.com: Emacs 22.1 hung after delete-process] Richard Stallman
2007-08-16 3:24 ` Glenn Morris
2007-08-16 4:46 ` dhruva
2007-08-17 0:32 ` Richard Stallman
2007-08-16 8:02 ` Jason Rumney
2007-08-16 12:42 ` dhruva
2007-08-16 14:09 ` dhruva
2007-08-16 17:04 ` dhruva
2007-08-16 19:41 ` Eli Zaretskii
2007-08-17 0:32 ` Richard Stallman
2007-08-17 5:27 ` dhruva
2007-08-27 10:07 ` dhruva
2007-09-02 17:02 ` Jason Rumney
2007-08-17 13:43 ` Jason Rumney
2007-08-17 17:31 ` dhruva
2007-08-17 20:40 ` Jason Rumney [this message]
2007-08-19 7:42 ` dhruva
2007-08-22 6:29 ` dhruva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C607B3.7060809@gnu.org \
--to=jasonr@gnu.org \
--cc=dhruvakm@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).