From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-15?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: C-x v l does not move to current log entry Date: Sun, 12 Aug 2007 10:30:26 +0200 Message-ID: <46BEC522.8010805@swipnet.se> References: <46B03B75.4000008@swipnet.se> <18099.60849.120058.919034@rgrjr.dyndns.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1186907491 13556 80.91.229.12 (12 Aug 2007 08:31:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 12 Aug 2007 08:31:31 +0000 (UTC) Cc: esr@snark.thyrsus.com, Bob Rogers , emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 12 10:31:28 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IK8r8-00060Z-C6 for ged-emacs-devel@m.gmane.org; Sun, 12 Aug 2007 10:31:26 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IK8r7-0004dw-Jz for ged-emacs-devel@m.gmane.org; Sun, 12 Aug 2007 04:31:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IK8r1-0004ZW-GF for emacs-devel@gnu.org; Sun, 12 Aug 2007 04:31:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IK8r0-0004Xp-ON for emacs-devel@gnu.org; Sun, 12 Aug 2007 04:31:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IK8r0-0004Xa-9u for emacs-devel@gnu.org; Sun, 12 Aug 2007 04:31:18 -0400 Original-Received: from av12-2-sn2.hy.skanova.net ([81.228.8.186]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IK8qy-0001IY-Kr; Sun, 12 Aug 2007 04:31:17 -0400 Original-Received: by av12-2-sn2.hy.skanova.net (Postfix, from userid 502) id 6F247380C1; Sun, 12 Aug 2007 10:31:10 +0200 (CEST) Original-Received: from smtp4-1-sn2.hy.skanova.net (smtp4-1-sn2.hy.skanova.net [81.228.8.92]) by av12-2-sn2.hy.skanova.net (Postfix) with ESMTP id 406E0380B9; Sun, 12 Aug 2007 10:31:10 +0200 (CEST) Original-Received: from husetbladh.homeip.net (81-235-205-78-no59.tbcn.telia.com [81.235.205.78]) by smtp4-1-sn2.hy.skanova.net (Postfix) with ESMTP id E218A37E45; Sun, 12 Aug 2007 10:31:09 +0200 (CEST) User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) In-Reply-To: X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76377 Archived-At: Richard Stallman skrev: > [I sent this message a week ago but did not get a response. > Could we get the discussion moving again?] >=20 Stefan Monnier has fixed this. Jan D. > Bob, thanks for making some progress. Would someone else please take > this the rest of the way, DTRT, and ack? >=20 > MIME-Version: 1.0 > Content-Type: multipart/mixed; boundary=3D"aPqeXV8Jxn" > Date: Fri, 3 Aug 2007 23:08:33 -0400 > From: Bob Rogers > To: rms@gnu.org > CC: emacs-devel@gnu.org, esr@snark.thyrsus.com > Subject: Re: C-x v l does not move to current log entry > In-Reply-To: >=20 >=20 > --aPqeXV8Jxn > Content-Type: text/plain; charset=3Diso-8859-1 > Content-Description: message body text > Content-Transfer-Encoding: 8bit >=20 > From: Richard Stallman > Date: Thu, 02 Aug 2007 11:45:17 -0400 >=20 > Would someone please DTRT and ack? >=20 > Date: Wed, 01 Aug 2007 09:51:17 +0200 > From: Jan Dj=E4rv >=20 > % emacs -Q src/gmalloc.c > C-x v l >=20 > The cursor stays at the top of the log view buffer. > Contrast this to emacs 22.1 where the cursor is positioned to the cu= rrent > log entry for the revision of src/gmalloc.c that you are editing. >=20 > Hmm. vc-default-show-log-entry does appear to be going to the right > place, but something is messing it up afterwards. I think I'll go to > bed now and let somebody who knows what they're doing have a crack at > it. ;-} >=20 > This from *Messages* may be relevant: >=20 > Running cvs log gmalloc.c in the background... done > Loading log-view... > Loading easy-mmode...done > Loading log-view...done > Error during redisplay: (void-function ,log-view-file-re) [2 times] >=20 > This turns out to be coming from log-view-font-lock-keywords, which has > a value that looks something like this: >=20 > ((eval \` (\,log-view-file-re (1 ...) (0 log-view-file-face append))) > (eval \` (\,log-view-message-re . log-view-message-face))) >=20 > The source (log-view.el:170) specifies backquoted forms inside a quoted > form; it appears that the reader is not handling this correctly. The > attached patch replaces the backquotes with explicit "cons" calls; this > is not a real fix, and I include it only to show that it does make the > error messages go away. Fixing the reader is undoubtedly hairier. >=20 > However, fixing the "Error during redisplay" problem does not affect > the original symptom. >=20 > Hope this is of some use, >=20 > -- Bob Rogers > http://rgrjr.dyndns.org/ >=20 >=20 > --aPqeXV8Jxn > Content-Type: text/plain > Content-Description:=20 > Content-Disposition: inline; > filename=3D"no-bq-in-log-view-flk-1.patch" > Content-Transfer-Encoding: 7bit >=20 > Index: lisp/log-view.el > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /sources/emacs/emacs/lisp/log-view.el,v > retrieving revision 1.37 > diff -c -r1.37 log-view.el > *** lisp/log-view.el 23 Jun 2007 03:06:21 -0000 1.37 > --- lisp/log-view.el 4 Aug 2007 02:41:52 -0000 > *************** > *** 170,179 **** > (defvar log-view-font-lock-keywords > ;; We use `eval' so as to use the buffer-local value of log-view-fi= le-re > ;; and log-view-message-re, if applicable. > ! '((eval . `(,log-view-file-re > ! (1 (if (boundp 'cvs-filename-face) cvs-filename-face)) > ! (0 log-view-file-face append))) > ! (eval . `(,log-view-message-re . log-view-message-face)))) > (defconst log-view-font-lock-defaults > '(log-view-font-lock-keywords t nil nil nil)) > =20 > --- 170,180 ---- > (defvar log-view-font-lock-keywords > ;; We use `eval' so as to use the buffer-local value of log-view-fi= le-re > ;; and log-view-message-re, if applicable. > ! '((eval . (cons log-view-file-re > ! '((1 (if (boundp 'cvs-filename-face) cvs-filename-face)) > ! (0 log-view-file-face append)))) > ! (eval . (cons log-view-message-re > ! 'log-view-message-face)))) > (defconst log-view-font-lock-defaults > '(log-view-font-lock-keywords t nil nil nil)) > =20 >=20 > --aPqeXV8Jxn-- >=20 >=20 >=20 > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-devel