From: "Jan Djärv" <jan.h.d@swipnet.se>
To: rms@gnu.org
Cc: esr@snark.thyrsus.com, Bob Rogers <rogers-emacs@rgrjr.dyndns.org>,
emacs-devel@gnu.org
Subject: Re: C-x v l does not move to current log entry
Date: Sun, 12 Aug 2007 10:30:26 +0200 [thread overview]
Message-ID: <46BEC522.8010805@swipnet.se> (raw)
In-Reply-To: <E1IK4r5-0006VJ-0a@fencepost.gnu.org>
Richard Stallman skrev:
> [I sent this message a week ago but did not get a response.
> Could we get the discussion moving again?]
>
Stefan Monnier has fixed this.
Jan D.
> Bob, thanks for making some progress. Would someone else please take
> this the rest of the way, DTRT, and ack?
>
> MIME-Version: 1.0
> Content-Type: multipart/mixed; boundary="aPqeXV8Jxn"
> Date: Fri, 3 Aug 2007 23:08:33 -0400
> From: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
> To: rms@gnu.org
> CC: emacs-devel@gnu.org, esr@snark.thyrsus.com
> Subject: Re: C-x v l does not move to current log entry
> In-Reply-To: <E1IGcrV-000310-Cs@fencepost.gnu.org>
>
>
> --aPqeXV8Jxn
> Content-Type: text/plain; charset=iso-8859-1
> Content-Description: message body text
> Content-Transfer-Encoding: 8bit
>
> From: Richard Stallman <rms@gnu.org>
> Date: Thu, 02 Aug 2007 11:45:17 -0400
>
> Would someone please DTRT and ack?
>
> Date: Wed, 01 Aug 2007 09:51:17 +0200
> From: Jan Djärv <jan.h.d@swipnet.se>
>
> % emacs -Q src/gmalloc.c
> C-x v l
>
> The cursor stays at the top of the log view buffer.
> Contrast this to emacs 22.1 where the cursor is positioned to the current
> log entry for the revision of src/gmalloc.c that you are editing.
>
> Hmm. vc-default-show-log-entry does appear to be going to the right
> place, but something is messing it up afterwards. I think I'll go to
> bed now and let somebody who knows what they're doing have a crack at
> it. ;-}
>
> This from *Messages* may be relevant:
>
> Running cvs log gmalloc.c in the background... done
> Loading log-view...
> Loading easy-mmode...done
> Loading log-view...done
> Error during redisplay: (void-function ,log-view-file-re) [2 times]
>
> This turns out to be coming from log-view-font-lock-keywords, which has
> a value that looks something like this:
>
> ((eval \` (\,log-view-file-re (1 ...) (0 log-view-file-face append)))
> (eval \` (\,log-view-message-re . log-view-message-face)))
>
> The source (log-view.el:170) specifies backquoted forms inside a quoted
> form; it appears that the reader is not handling this correctly. The
> attached patch replaces the backquotes with explicit "cons" calls; this
> is not a real fix, and I include it only to show that it does make the
> error messages go away. Fixing the reader is undoubtedly hairier.
>
> However, fixing the "Error during redisplay" problem does not affect
> the original symptom.
>
> Hope this is of some use,
>
> -- Bob Rogers
> http://rgrjr.dyndns.org/
>
>
> --aPqeXV8Jxn
> Content-Type: text/plain
> Content-Description:
> Content-Disposition: inline;
> filename="no-bq-in-log-view-flk-1.patch"
> Content-Transfer-Encoding: 7bit
>
> Index: lisp/log-view.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/log-view.el,v
> retrieving revision 1.37
> diff -c -r1.37 log-view.el
> *** lisp/log-view.el 23 Jun 2007 03:06:21 -0000 1.37
> --- lisp/log-view.el 4 Aug 2007 02:41:52 -0000
> ***************
> *** 170,179 ****
> (defvar log-view-font-lock-keywords
> ;; We use `eval' so as to use the buffer-local value of log-view-file-re
> ;; and log-view-message-re, if applicable.
> ! '((eval . `(,log-view-file-re
> ! (1 (if (boundp 'cvs-filename-face) cvs-filename-face))
> ! (0 log-view-file-face append)))
> ! (eval . `(,log-view-message-re . log-view-message-face))))
> (defconst log-view-font-lock-defaults
> '(log-view-font-lock-keywords t nil nil nil))
>
> --- 170,180 ----
> (defvar log-view-font-lock-keywords
> ;; We use `eval' so as to use the buffer-local value of log-view-file-re
> ;; and log-view-message-re, if applicable.
> ! '((eval . (cons log-view-file-re
> ! '((1 (if (boundp 'cvs-filename-face) cvs-filename-face))
> ! (0 log-view-file-face append))))
> ! (eval . (cons log-view-message-re
> ! 'log-view-message-face))))
> (defconst log-view-font-lock-defaults
> '(log-view-font-lock-keywords t nil nil nil))
>
>
> --aPqeXV8Jxn--
>
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2007-08-12 8:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 7:51 C-x v l does not move to current log entry Jan Djärv
2007-08-02 15:45 ` Richard Stallman
2007-08-04 3:08 ` Bob Rogers
2007-08-05 3:06 ` Richard Stallman
2007-08-10 8:09 ` Stefan Monnier
2007-08-12 4:15 ` Richard Stallman
2007-08-12 8:30 ` Jan Djärv [this message]
2007-08-12 22:01 ` Stefan Monnier
2007-08-13 6:03 ` Jan Djärv
2007-09-10 6:53 ` Jan Djärv
2007-09-12 8:30 ` Glenn Morris
2007-09-14 6:41 ` Jan Djärv
2007-09-15 22:25 ` Stefan Monnier
2007-09-16 8:55 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BEC522.8010805@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
--cc=esr@snark.thyrsus.com \
--cc=rms@gnu.org \
--cc=rogers-emacs@rgrjr.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).