Re: [offby1@blarg.net: doc string discrepancy in ibuffer-mark-old-buffers]

[Vinicius Jose Latorre <viniciusjl@ig.com.br>]

Done.

The patch was applied in trunk and Emacs 22 branch.


Richard Stallman wrote:
> [I sent this message twice but did not get a response.]
>
> Would someone please DTRT, then ack?
>
> ------- Start of forwarded message -------
> X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_PASS,UNPARSEABLE_RELAY 
> 	autolearn=failed version=3.1.0
> To: emacs-pretest-bug@gnu.org
> From: Eric Hanchrow <offby1@blarg.net>
> Date: Tue, 26 Jun 2007 11:46:58 -0700
> MIME-Version: 1.0
> Content-Type: text/plain; charset=us-ascii
> Subject: doc string discrepancy in ibuffer-mark-old-buffers
>
>
> Please write in English if possible, because the Emacs maintainers
> usually do not have translators to read other languages for them.
>
> Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.
>
> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:
>
> In ibuffer mode, I read the doc string for the . key, and it said
>
>     ibuffer-mark-old-buffers is an interactive compiled Lisp function in `ibuf-ext.el'.
>     (ibuffer-mark-old-buffers)
>
>     Mark buffers which have not been viewed in `ibuffer-old-time' days.
>
>     [back]
>
> I then followed the link for the `ibuffer-old-time' variable, and
> noted that it said
>
>     The number of hours before a buffer is considered "old".
>
> So I checked the source, and it looks like "hours" is indeed correct.
>
> Here's the obvious patch to fix it:
>
>     --- ibuf-ext.el	20 Jan 2007 19:53:11 -0800	1.53
>     +++ ibuf-ext.el	26 Jun 2007 11:43:25 -0700	
>     @@ -1482,7 +1482,7 @@
>
>      ;;;###autoload
>      (defun ibuffer-mark-old-buffers ()
>     -  "Mark buffers which have not been viewed in `ibuffer-old-time' days."
>     +  "Mark buffers which have not been viewed in `ibuffer-old-time' hours."
>        (interactive)
>        (ibuffer-mark-on-buffer
>         #'(lambda (buf)
>
> If Emacs crashed, and you have the Emacs process in the gdb debugger,
> please include the output from the following gdb commands:
>     `bt full' and `xbacktrace'.
> If you would like to further debug the crash, please read the file
> /usr/local/src/emacs-cvs/etc/DEBUG for instructions.
>
>
> In GNU Emacs 22.1.50.3 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
>  of 2007-06-13 on debian
> configured using `configure  '--enable-maintainer-mode''
>
> Important settings:
>   value of $LC_ALL: nil
>   value of $LC_COLLATE: nil
>   value of $LC_CTYPE: nil
>   value of $LC_MESSAGES: nil
>   value of $LC_MONETARY: nil
>   value of $LC_NUMERIC: nil
>   value of $LC_TIME: nil
>   value of $LANG: nil
>   locale-coding-system: utf-8
>   default-enable-multibyte-characters: t
>
> Major mode: Emacs-Lisp
>
> Minor modes in effect:
>   auto-fill-function: do-auto-fill
>   erc-ring-mode: t
>   erc-pcomplete-mode: t
>   erc-netsplit-mode: t
>   eldoc-mode: t
>   erc-button-mode: t
>   erc-fill-mode: t
>   erc-stamp-mode: t
>   erc-autojoin-mode: t
>   erc-track-mode: t
>   erc-track-minor-mode: t
>   erc-match-mode: t
>   erc-log-mode: t
>   erc-services-mode: t
>   erc-irccontrols-mode: t
>   erc-noncommands-mode: t
>   erc-readonly-mode: t
>   recentf-mode: t
>   display-time-mode: t
>   shell-dirtrack-mode: t
>   iswitchb-mode: t
>   encoded-kbd-mode: t
>   mouse-wheel-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   unify-8859-on-encoding-mode: t
>   utf-translate-cjk-mode: t
>   auto-compression-mode: t
>   line-number-mode: t
>   transient-mark-mode: t
>
> Recent input:
> o u SPC r e f e r r i n g SPC t o SPC s o u r c e f 
> o r g e . n e t SPC ? ESC b ESC d DEL RET t o _ TAB 
> d o SPC y o u SPC i n SPC f a c t SPC _ h a v e _ SPC 
> a SPC p o s t - ESC DEL p r e - c ESC / SPC h o o k 
> ? C-a ESC f ESC f ESC DEL c a n ESC f ESC d ESC d ESC 
> d C-d SPC p a s t e ESC d SPC t h e RET C-c C-@ C-c 
> C-@ m a y b e ESC DEL y o u SPC w i l l SPC n e e d 
> SPC t o SPC f i g u r e SPC o u t SPC w h a t ' s SPC 
> i n SPC i t , SPC t o SPC u n d e r s t a n d SPC t 
> h i s SPC p r o b l e m . RET i t ' DEL SPC m n i g 
> h t C-u C-b C-b C-d C-e C-c C-u C-c C-@ C-x C-b . s 
> s C-h l * * RET C-h c C-x C-b C-h c . C-x 1 . D y s 
> v . C-h K . q C-h k . C-x o TAB TAB RET TAB TAB TAB 
> RET ESC < TAB RET C-n C-e ESC b ESC d h o u r s C-x 
> C-s C-x 1 C-x v = C-x 0 ESC x r e p o r t - e m TAB 
> b TAB RET
>
> Recent messages:
> Type C-x 1 to remove help window.  
> mouse-2, RET: find function's definition
> mouse-2, RET: describe this variable
> mouse-2, RET: find variable's definition
> mouse-2, RET: customize variable
> mouse-2, RET: go back to previous help buffer
> Mark set
> mouse-2, RET: find function's definition
> Saving file /usr/local/src/emacs-cvs/lisp/ibuf-ext.el...
> Wrote /usr/local/src/emacs-cvs/lisp/ibuf-ext.el
>
> - -- 
> When it comes to electronic voting, most liberals are just plain
> old-fashioned nuts.
>         -- Joe Andrew, former chairman of the Democratic National
>            Committee
>