* [schierlm@gmx.de: Misleading error message when defining empty keyboard macro and no keyboard macro has been defined yet.]
@ 2007-07-09 14:29 Richard Stallman
0 siblings, 0 replies; 4+ messages in thread
From: Richard Stallman @ 2007-07-09 14:29 UTC (permalink / raw)
To: emacs-devel
Would someone please DTRT, then ack?
------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY
autolearn=failed version=3.1.0
Date: Sun, 08 Jul 2007 21:14:16 +0200
From: Michael Schierl <schierlm@gmx.de>
MIME-Version: 1.0
To: bug-gnu-emacs@gnu.org
Content-Type: text/plain; charset=ISO-8859-15
Subject: Misleading error message when defining empty keyboard macro and no
keyboard macro has been defined yet.
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:
- - Start emacs with -Q
- - Press <f3> and immediately <f4>
Result (in echo area):
Only one keyboard macro defined.
Huh? In fact, there are only *zero* keyboard macros defined (if you do
not count the empty one that has been ignored).
Expected result:
Ignore empty macro
[full *Messages* are below.]
In GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600)
of 2007-06-02 on RELEASE
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: DEU
locale-coding-system: cp1252
default-enable-multibyte-characters: t
Major mode: Lisp Interaction
Minor modes in effect:
encoded-kbd-mode: t
tooltip-mode: t
tool-bar-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
unify-8859-on-encoding-mode: t
utf-translate-cjk-mode: t
auto-compression-mode: t
line-number-mode: t
Recent input:
<f3> <f4> M-x r e p o r t - e <tab> <return>
Recent messages:
Loading encoded-kb...done
For information about the GNU Project and its goals, type C-h C-p.
Loading kmacro...done
Defining kbd macro...
Keyboard macro defined
Ignore empty macro
Only one keyboard macro defined.
Loading emacsbug...
Loading regexp-opt...done
Loading emacsbug...done
_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------
^ permalink raw reply [flat|nested] 4+ messages in thread
* [schierlm@gmx.de: Misleading error message when defining empty keyboard macro and no keyboard macro has been defined yet.]
@ 2007-07-17 3:34 Richard Stallman
2007-07-17 9:27 ` martin rudalics
0 siblings, 1 reply; 4+ messages in thread
From: Richard Stallman @ 2007-07-17 3:34 UTC (permalink / raw)
To: emacs-devel
[I sent this message a week ago but did not get a response.]
Would someone please DTRT, then ack?
------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY
autolearn=failed version=3.1.0
Date: Sun, 08 Jul 2007 21:14:16 +0200
From: Michael Schierl <schierlm@gmx.de>
MIME-Version: 1.0
To: bug-gnu-emacs@gnu.org
Content-Type: text/plain; charset=ISO-8859-15
Subject: Misleading error message when defining empty keyboard macro and no
keyboard macro has been defined yet.
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:
- - Start emacs with -Q
- - Press <f3> and immediately <f4>
Result (in echo area):
Only one keyboard macro defined.
Huh? In fact, there are only *zero* keyboard macros defined (if you do
not count the empty one that has been ignored).
Expected result:
Ignore empty macro
[full *Messages* are below.]
In GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600)
of 2007-06-02 on RELEASE
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Ic:/gnuwin32/include'
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: DEU
locale-coding-system: cp1252
default-enable-multibyte-characters: t
Major mode: Lisp Interaction
Minor modes in effect:
encoded-kbd-mode: t
tooltip-mode: t
tool-bar-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
unify-8859-on-encoding-mode: t
utf-translate-cjk-mode: t
auto-compression-mode: t
line-number-mode: t
Recent input:
<f3> <f4> M-x r e p o r t - e <tab> <return>
Recent messages:
Loading encoded-kb...done
For information about the GNU Project and its goals, type C-h C-p.
Loading kmacro...done
Defining kbd macro...
Keyboard macro defined
Ignore empty macro
Only one keyboard macro defined.
Loading emacsbug...
Loading regexp-opt...done
Loading emacsbug...done
_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
------- End of forwarded message -------
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [schierlm@gmx.de: Misleading error message when defining empty keyboard macro and no keyboard macro has been defined yet.]
2007-07-17 3:34 [schierlm@gmx.de: Misleading error message when defining empty keyboard macro and no keyboard macro has been defined yet.] Richard Stallman
@ 2007-07-17 9:27 ` martin rudalics
2007-07-17 17:55 ` Michael Schierl
0 siblings, 1 reply; 4+ messages in thread
From: martin rudalics @ 2007-07-17 9:27 UTC (permalink / raw)
To: rms; +Cc: schierlm, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
> - - Start emacs with -Q
> - - Press <f3> and immediately <f4>
>
> Result (in echo area):
> Only one keyboard macro defined.
>
> Huh? In fact, there are only *zero* keyboard macros defined (if you do
> not count the empty one that has been ignored).
>
> Expected result:
> Ignore empty macro
Michael, could you please test the attached patch? Could you also
test whether it has unwanted side-effects? Thanks.
[-- Attachment #2: kmacro.patch --]
[-- Type: text/plain, Size: 763 bytes --]
*** kmacro.el Wed Jan 17 09:30:52 2007
--- kmacro.el Tue Jul 17 11:25:20 2007
***************
*** 606,613 ****
(unless executing-kbd-macro
(end-kbd-macro arg #'kmacro-loop-setup-function)
(when (and last-kbd-macro (= (length last-kbd-macro) 0))
(message "Ignore empty macro")
! (kmacro-pop-ring))))
;;;###autoload
--- 606,616 ----
(unless executing-kbd-macro
(end-kbd-macro arg #'kmacro-loop-setup-function)
(when (and last-kbd-macro (= (length last-kbd-macro) 0))
+ (setq last-kbd-macro nil)
(message "Ignore empty macro")
! ;; Don't call `kmacro-ring-empty-p' to avoid its messages.
! (while (and (null last-kbd-macro) kmacro-ring)
! (kmacro-pop-ring1)))))
;;;###autoload
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [schierlm@gmx.de: Misleading error message when defining empty keyboard macro and no keyboard macro has been defined yet.]
2007-07-17 9:27 ` martin rudalics
@ 2007-07-17 17:55 ` Michael Schierl
0 siblings, 0 replies; 4+ messages in thread
From: Michael Schierl @ 2007-07-17 17:55 UTC (permalink / raw)
To: martin rudalics; +Cc: rms, emacs-devel
martin rudalics schrieb:
>> - - Start emacs with -Q
>> - - Press <f3> and immediately <f4>
>>
>> Result (in echo area):
>> Only one keyboard macro defined.
> Michael, could you please test the attached patch? Could you also
> test whether it has unwanted side-effects? Thanks.
Works fine for me. I did not find any unwanted side effects (but that
does not necessarily mean that there are none).
Michael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-17 17:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-17 3:34 [schierlm@gmx.de: Misleading error message when defining empty keyboard macro and no keyboard macro has been defined yet.] Richard Stallman
2007-07-17 9:27 ` martin rudalics
2007-07-17 17:55 ` Michael Schierl
-- strict thread matches above, loose matches on Subject: below --
2007-07-09 14:29 Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).