unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* no other window
@ 2007-07-16 11:07 Robert J. Chassell
  2007-07-16 13:03 ` martin rudalics
  0 siblings, 1 reply; 3+ messages in thread
From: Robert J. Chassell @ 2007-07-16 11:07 UTC (permalink / raw)
  To: emacs-devel

Today's GNU Emacs CVS snapshot, Mon, 2007 Jul 16  10:38 UTC
GNU Emacs 22.1.50.73 (i686-pc-linux-gnu, GTK+ Version 2.10.13)
started with
    /usr/local/src/emacs/src/emacs -Q -D
and with
    /usr/local/src/emacs/src/emacs -Q -D -nw

Starting yesterday and today's snapshots of Emacs, I could not get
other windows, just the one.  

That is to say, 

    `C-x 4 C-f' (find-file-other-window)

acts like 

    `C-x C-f' (find-file)

Saturday's snapshot works fine.

I could not see anything wrong with the recent changes to src/window.c

This first occured yesterday, 15 July 2007.

-- 
    Robert J. Chassell                          GnuPG Key ID: 004B4AC8
    bob@rattlesnake.com                         bob@gnu.org
    http://www.rattlesnake.com                  http://www.teak.cc

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: no other window
  2007-07-16 11:07 no other window Robert J. Chassell
@ 2007-07-16 13:03 ` martin rudalics
  2007-07-16 18:37   ` Robert J. Chassell
  0 siblings, 1 reply; 3+ messages in thread
From: martin rudalics @ 2007-07-16 13:03 UTC (permalink / raw)
  To: bob; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

 > Today's GNU Emacs CVS snapshot, Mon, 2007 Jul 16  10:38 UTC
 > GNU Emacs 22.1.50.73 (i686-pc-linux-gnu, GTK+ Version 2.10.13)
 > started with
 >     /usr/local/src/emacs/src/emacs -Q -D
 > and with
 >     /usr/local/src/emacs/src/emacs -Q -D -nw
 >
 > Starting yesterday and today's snapshots of Emacs, I could not get
 > other windows, just the one.
 >
 > That is to say,
 >
 >     `C-x 4 C-f' (find-file-other-window)
 >
 > acts like
 >
 >     `C-x C-f' (find-file)
 >
 > Saturday's snapshot works fine.
 >
 > I could not see anything wrong with the recent changes to src/window.c
 >
 > This first occured yesterday, 15 July 2007.
 >

Thanks for reporting.  Would the attached patch fix it?

[-- Attachment #2: window.c.patch --]
[-- Type: text/plain, Size: 1758 bytes --]

*** window.c	Mon Jul 16 14:58:10 2007
--- window.c	Mon Jul 16 14:59:28 2007
***************
*** 3743,3749 ****
        if (!NILP (window)
  	  && ! FRAME_NO_SPLIT_P (XFRAME (XWINDOW (window)->frame))
  	  && WINDOW_FULL_WIDTH_P (XWINDOW (window))
! 	  && window_height (window) >= split_height_threshold
  	  && (window_height (window)
  	      >= (2 * window_min_size_2 (XWINDOW (window), 0))))
  	window = Fsplit_window (window, Qnil, Qnil);
--- 3743,3750 ----
        if (!NILP (window)
  	  && ! FRAME_NO_SPLIT_P (XFRAME (XWINDOW (window)->frame))
  	  && WINDOW_FULL_WIDTH_P (XWINDOW (window))
! 	  && ((window_height (window) >= split_height_threshold)
! 	      || (EQ (XWINDOW (window)->parent, Qnil)))
  	  && (window_height (window)
  	      >= (2 * window_min_size_2 (XWINDOW (window), 0))))
  	window = Fsplit_window (window, Qnil, Qnil);
***************
*** 3756,3764 ****
  	     and can be split, split it.  */
  	  if (!NILP (window)
  	      && ! FRAME_NO_SPLIT_P (XFRAME (XWINDOW (window)->frame))
! 	      && (EQ (window, selected_window)
! 		  || EQ (XWINDOW (window)->parent, Qnil))
! 	      && window_height (window) >= split_height_threshold
  	      && (window_height (window)
  		  >= (2 * window_min_size_2 (XWINDOW (window), 0))))
  	    window = Fsplit_window (window, Qnil, Qnil);
--- 3757,3765 ----
  	     and can be split, split it.  */
  	  if (!NILP (window)
  	      && ! FRAME_NO_SPLIT_P (XFRAME (XWINDOW (window)->frame))
! 	      && (((EQ (window, selected_window))
! 		   && (window_height (window) >= split_height_threshold))
! 		  || (EQ (XWINDOW (window)->parent, Qnil)))
  	      && (window_height (window)
  		  >= (2 * window_min_size_2 (XWINDOW (window), 0))))
  	    window = Fsplit_window (window, Qnil, Qnil);

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: no other window
  2007-07-16 13:03 ` martin rudalics
@ 2007-07-16 18:37   ` Robert J. Chassell
  0 siblings, 0 replies; 3+ messages in thread
From: Robert J. Chassell @ 2007-07-16 18:37 UTC (permalink / raw)
  To: emacs-devel

 > Starting yesterday and today's snapshots of Emacs, I could not get
 > other windows, just the one.

martin rudalics <rudalics@gmx.at> said

    Thanks for reporting.  Would the attached patch fix it?

Yes, it does; I am writing in a new instance now.  Many thanks.

-- 
    Robert J. Chassell                          GnuPG Key ID: 004B4AC8
    bob@rattlesnake.com                         bob@gnu.org
    http://www.rattlesnake.com                  http://www.teak.cc

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-07-16 18:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-16 11:07 no other window Robert J. Chassell
2007-07-16 13:03 ` martin rudalics
2007-07-16 18:37   ` Robert J. Chassell

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).