From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Alex Plotnick Newsgroups: gmane.emacs.devel Subject: Re: Patch for network-interface-{list,info} Date: Tue, 18 Nov 2003 00:49:40 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <46933.699414558$1069134801@news.gmane.org> References: <87ad6w2hm6.fsf@Dora.local.> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1069134801 32719 80.91.224.253 (18 Nov 2003 05:53:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 18 Nov 2003 05:53:21 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Nov 18 06:53:17 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1ALynd-0001ku-00 for ; Tue, 18 Nov 2003 06:53:17 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1ALynd-00039A-00 for ; Tue, 18 Nov 2003 06:53:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ALzis-0005Ln-25 for emacs-devel@quimby.gnus.org; Tue, 18 Nov 2003 01:52:26 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1ALziA-0005LU-DL for emacs-devel@gnu.org; Tue, 18 Nov 2003 01:51:42 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1ALzhd-00057F-0C for emacs-devel@gnu.org; Tue, 18 Nov 2003 01:51:40 -0500 Original-Received: from [204.127.198.35] (helo=rwcrmhc11.comcast.net) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ALzhc-00053F-ER; Tue, 18 Nov 2003 01:51:08 -0500 Original-Received: from milo.localdomain (pcp04988064pcs.benslm01.pa.comcast.net[68.81.104.105]) by comcast.net (rwcrmhc11) with ESMTP id <2003111805494201300hujq6e>; Tue, 18 Nov 2003 05:49:42 +0000 Original-Received: from Dora.local. (gateway.localdomain [192.168.0.1]) by milo.localdomain (Postfix) with ESMTP id CA309144895A; Tue, 18 Nov 2003 00:49:40 -0500 (EST) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "17 Nov 2003 13:23:32 +0100") User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3.50 (darwin) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:17875 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17875 storm@cua.dk (Kim F. Storm) writes: > It's definitely a cleaner interface, yes, and maybe it is as widely > available as SIOCGIFCONF these days...? I agree that it's much cleaner. As far as I know, the free BSDs all have it, and it's in glibc on GNU/Linux. Irix doesn't have it; I don't know about Solaris. > But in any case, since network-interface-list is a new addition in CVS > emacs, I think it would be alright for us to restrict its availability > to those systems which do support getifaddrs. This seems reasonable to me. If anyone knows of a good reason why this is not an acceptable course of action, please let me know. > How does getifaddrs return the hw address? In ifaddr->ifa_data ? > Is that portable? If not, maybe it could use SIOCGIFHWADDR as > a fallback. getifaddrs() actually returns *two* entries for each interface: one describes the layer-3 address, and the other the link-layer address. Which one is which is determined by examining the sa_family of the given sockaddr (ifa_addr). On BSD, this sockaddr is actually a struct sockaddr_dl and has family AF_LINK, whereas on GNU/Linux it's an AF_PACKET and is described by a struct sockaddr_ll. There's no need to muck around with the raw ifa_data field. > If you want to modify network-interface-list and -info according to > the suggestions above, I would appreciate it. I'll send a patch in the next day or two. > Are you interested in signing papers for your changes? This is no problem. If the relevant party contacts me privately via email, I'll be happy to provide a mailing address for whatever paperwork is necessary. Thanks, Alex Plotnick