From: martin rudalics <rudalics@gmx.at>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: insert-file-contents and format-decode
Date: Tue, 19 Jun 2007 09:50:35 +0200 [thread overview]
Message-ID: <46778ACB.1000704@gmx.at> (raw)
In-Reply-To: <E1I0Ool-0008Bz-9q@fencepost.gnu.org>
> I test the attached patch for a week now and didn't encounter any
> problems. In addition to fixing the bug I described it moves the call
> of after-change hooks _after_ the call to `after-insert-file-functions'.
>
> That seems like a mistake to me. The `after-insert-file-functions'
> are Lisp functions, and if they change the buffer, they will call the
> after change hooks for what they did. Therefore, the calls to the
> after change hooks for this function's own direct changes in the
> buffer should be done before.
(1) The `format-decode' ("round-trip" as the new Elisp manual entry
calls them) based functions are Lisp functions, may change the buffer,
and may call the after-change functions for what they do. They precede,
within `insert-file-contents', the after-change-functions call. If a
distinction between round-trip and "piecemeal" functions with respect to
calling after-change-functions is desired it should be documented.
(2) Calling `after-change-functions' from within `format-decode' or
`after-insert-file-functions' seems to me highly risky. Personally, I'd
never trust any of them if they don't use `inhibit-modification-hooks'.
(3) Not calling `after-change-functions' after performing all functions
in `after-insert-file-functions' may mean, for example, not executing
`font-lock-after-change-function' after inserting the contents of some
file in the current buffer.
I think the only live and safe place to call `after-change-functions' is
after the entire file contents have been decoded, that means, after all
functions in `after-insert-file-functions' have been called.
next prev parent reply other threads:[~2007-06-19 7:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 14:06 insert-file-contents and format-decode martin rudalics
2007-06-08 7:12 ` Richard Stallman
2007-06-17 13:34 ` martin rudalics
2007-06-18 21:31 ` Richard Stallman
2007-06-19 7:50 ` martin rudalics [this message]
2007-06-23 18:26 ` Richard Stallman
2007-06-23 18:26 ` Richard Stallman
2007-06-24 10:30 ` martin rudalics
2007-06-25 13:19 ` Richard Stallman
2007-06-26 6:54 ` martin rudalics
2007-06-26 22:48 ` Richard Stallman
2007-06-27 6:33 ` martin rudalics
2007-06-27 19:50 ` Richard Stallman
2007-06-30 11:11 ` martin rudalics
2007-07-01 0:30 ` Richard Stallman
2007-07-02 8:14 ` martin rudalics
2007-07-03 4:24 ` Richard Stallman
2007-07-03 6:47 ` martin rudalics
2007-07-04 3:43 ` Richard Stallman
2007-06-26 22:48 ` Richard Stallman
2007-06-27 6:34 ` martin rudalics
2007-06-27 23:43 ` Richard Stallman
2007-06-30 11:32 ` martin rudalics
2007-07-01 0:30 ` Richard Stallman
2007-07-02 8:27 ` martin rudalics
2007-07-03 4:24 ` Richard Stallman
2007-07-03 6:43 ` martin rudalics
2007-08-06 14:22 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46778ACB.1000704@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).