From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] RFC: eldoc-documentation-functions hook Date: Sun, 12 Jun 2016 22:50:37 +0300 Message-ID: <46625727-4d14-22fc-15e8-8036e135b51f@yandex.ru> References: <20160612061229.GA6463@holos.localdomain> <20160612185237.GA12617@holos.localdomain> <20160612194452.GA12853@holos.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1465761065 25171 80.91.229.3 (12 Jun 2016 19:51:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 12 Jun 2016 19:51:05 +0000 (UTC) Cc: emacs-devel@gnu.org, Noam Postavsky To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 12 21:51:00 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bCBPL-0001Pn-UW for ged-emacs-devel@m.gmane.org; Sun, 12 Jun 2016 21:50:56 +0200 Original-Received: from localhost ([::1]:52516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCBPK-0004Ux-SH for ged-emacs-devel@m.gmane.org; Sun, 12 Jun 2016 15:50:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCBPD-0004Up-1W for emacs-devel@gnu.org; Sun, 12 Jun 2016 15:50:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCBP8-0000Wo-TU for emacs-devel@gnu.org; Sun, 12 Jun 2016 15:50:46 -0400 Original-Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:37862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCBP8-0000WY-Hp for emacs-devel@gnu.org; Sun, 12 Jun 2016 15:50:42 -0400 Original-Received: by mail-wm0-x234.google.com with SMTP id k204so53705156wmk.0 for ; Sun, 12 Jun 2016 12:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=Xi2bgEoWvGie4ASt3FQS43dPkEeE9cBORBoe+w+PE9s=; b=D/ePUyRnGMOyOJTt3SeQ6nos/06h63p/VRCn0frsIM4+EmWYMJKUHG4wQ4x57y2DH5 LvVWaxsZ5otrJcdB1yVOCf3vXxr9vojVX6OJKyyR09OZOIdf4c8xNoCcUOkqVyaebsdP FEUGV6a35Q/75CcJTyxMlwBWvVN+z1KI5qny93gkXITgsfFoOHZOIm6m5VB5PbY/RJja rkM3Tuladoc7lIIUFS9IBOPeeCVi6lfuOX4PBjWYxnKFPtQ145ZQH6ohhNHLeCPhdYmF cDi2UUPCTsjP5wMFPBEvqbLinftB0aX8rpujRT37Kki3IyyigY+9rZhAzFAEtSN86MgD IWbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Xi2bgEoWvGie4ASt3FQS43dPkEeE9cBORBoe+w+PE9s=; b=lLEy0rr36XhjYJksPmpr7Ob8BcE61ImlJnHWpKaszAW/eNZHuskmfyo/5t8KUCrDrq OLsHEk5nmdHvZyxaQUWD9DFMQCvEYu2nz7v8rNeac331LdgA10Cp9/hssOv5EfOoSaEj q2ct715xIu147qCypCKBI1uef/FEu1fapN4G3aaVRBMbNqzM/tihEMEaxI7+zNCAjb9w 7NOaepDDGe5dB/YG6s0BDuKO3IIpre0Tax5YdaOsIij1JE4BlVATE1KbzmUaE480qMZq bzXn09cFM9L/iuK1cHk3A9UCiJLdi82wSWCn7xgQoMneB72/nl6xbNrEgm41fiky35B4 /BRw== X-Gm-Message-State: ALyK8tJf1I5HlQDdv+9ptPxh3GFE3m22FpkK2c2NMtv9pKrTxUJV4pTb5+BqOvlJnS3emw== X-Received: by 10.28.38.5 with SMTP id m5mr8369801wmm.82.1465761041714; Sun, 12 Jun 2016 12:50:41 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id e5sm23760881wjj.10.2016.06.12.12.50.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 12 Jun 2016 12:50:40 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 In-Reply-To: <20160612194452.GA12853@holos.localdomain> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204320 Archived-At: On 06/12/2016 10:44 PM, Mark Oteiza wrote: >> add-function is more powerful than hooks, see the different ways you can >> combine the functions. > > That does not mean we should be using advice where hooks are a natural > solution. Maybe, maybe not. After introducing nadvice, it was Stefan's position that most hooks should be replaced with using advice, and eldoc-documentation-function in particular. I don't know how I feel about "most hooks", but there doesn't seem to be a strong reason to reverse his choice on this one variable. > Nothing prevents you from using add-function on a hook I don't think that's possible. > or a function > that is part of a hook. You'd have to know the names of the individual functions in advance.