[mituharu@math.s.chiba-u.ac.jp: Cursors in fringe not redrawn by expose events.]

[mituharu@math.s.chiba-u.ac.jp: Cursors in fringe not redrawn by expose events.]

[Richard Stallman]

Would someone please DTRT and ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.5 required=5.0 tests=DNS_FROM_RFC_ABUSE,
	UNPARSEABLE_RELAY autolearn=no version=3.1.0
Date: Wed, 25 Apr 2007 17:46:53 +0900
From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: emacs-pretest-bug@gnu.org
Organization: Faculty of Science, Chiba University
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Subject: Cursors in fringe not redrawn by expose events.

Cursors in the fringe area don't get redrawn by expose events.

1) emacs -Q -D
2) `C-u 80 SPC' and move the cursor to the right fringe.
3) Move the frame so the cursor area goes outside the screen.
4) Move back the frame to the original position.

Whether the step 4 causes expose events or not would depend on the X
server.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/home/mituharu/src/cvs/emacs/etc/DEBUG for instructions.


In GNU Emacs 22.0.99.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2007-04-25 on localhost.localdomain
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40300000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ja_JP.eucJP
  locale-coding-system: japanese-iso-8bit
  default-enable-multibyte-characters: t


_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

Re: [mituharu@math.s.chiba-u.ac.jp: Cursors in fringe not redrawn by expose events.]

[Kim F. Storm]

Richard Stallman <rms@gnu.org> writes:

> Would someone please DTRT and ack?

I thought we wanted to make a release soon ?!?!?

IMO, TRT is to delay fixing this !

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: [mituharu@math.s.chiba-u.ac.jp: Cursors in fringe not redrawn by expose events.]

[Chong Yidong]

storm@cua.dk (Kim F. Storm) writes:

> Richard Stallman <rms@gnu.org> writes:
>
>> Would someone please DTRT and ack?
>
> I thought we wanted to make a release soon ?!?!?

I was also under that impression.

I suggest removing this from FOR-RELEASE.

Re: [mituharu@math.s.chiba-u.ac.jp: Cursors in fringe not redrawn by expose events.]

[Richard Stallman]

I'd like someone to look at this bug.

Re: [mituharu@math.s.chiba-u.ac.jp: Cursors in fringe not redrawn by expose events.]

[Jan Djärv]

Chong Yidong skrev:
> storm@cua.dk (Kim F. Storm) writes:
> 
>> Richard Stallman <rms@gnu.org> writes:
>>
>>> Would someone please DTRT and ack?
>> I thought we wanted to make a release soon ?!?!?
> 
> I was also under that impression.
> 
> I suggest removing this from FOR-RELEASE.

FWIW I can't even reproduce the bug.  Let's get on with the release.

	Jan D.

Re: [mituharu@math.s.chiba-u.ac.jp: Cursors in fringe not redrawn by expose events.]

[YAMAMOTO Mitsuharu]

>>>>> On Sat, 28 Apr 2007 00:07:28 -0400, Richard Stallman <rms@gnu.org> said:

> I'd like someone to look at this bug.

I tried it for myself.  Of course, I leave the decision to experts.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Index: src/xdisp.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
retrieving revision 1.1149
diff -c -p -r1.1149 xdisp.c
*** src/xdisp.c	24 Apr 2007 01:32:41 -0000	1.1149
--- src/xdisp.c	28 Apr 2007 10:49:57 -0000
*************** phys_cursor_in_rect_p (w, r)
*** 23403,23408 ****
--- 23403,23426 ----
  {
    XRectangle cr, result;
    struct glyph *cursor_glyph;
+   struct glyph_row *row;
+ 
+   if (w->phys_cursor.vpos >= 0
+       && w->phys_cursor.vpos < w->current_matrix->nrows
+       && (row = MATRIX_ROW (w->current_matrix, w->phys_cursor.vpos),
+ 	  row->enabled_p)
+       && row->cursor_in_fringe_p)
+     {
+       /* Cursor is in the fringe.  */
+       cr.x = window_box_right_offset (w,
+ 				      (WINDOW_HAS_FRINGES_OUTSIDE_MARGINS (w)
+ 				       ? RIGHT_MARGIN_AREA
+ 				       : TEXT_AREA));
+       cr.y = row->y;
+       cr.width = WINDOW_RIGHT_FRINGE_WIDTH (w);
+       cr.height = row->height;
+       return x_intersect_rectangles (&cr, r, &result);
+     }
  
    cursor_glyph = get_phys_cursor_glyph (w);
    if (cursor_glyph)