From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.devel Subject: Re: The doc string for a globalized minor mode should linke to the mode Date: Wed, 18 Apr 2007 17:23:34 +0200 Message-ID: <462637F6.6080107@gmail.com> References: <4624A556.1080005@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1176909822 8900 80.91.229.12 (18 Apr 2007 15:23:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 18 Apr 2007 15:23:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 18 17:23:35 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HeC0H-00034X-Hu for ged-emacs-devel@m.gmane.org; Wed, 18 Apr 2007 17:23:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HeC57-0005Y7-MW for ged-emacs-devel@m.gmane.org; Wed, 18 Apr 2007 11:28:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HeC54-0005Xx-D2 for emacs-devel@gnu.org; Wed, 18 Apr 2007 11:28:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HeC51-0005Xh-Np for emacs-devel@gnu.org; Wed, 18 Apr 2007 11:28:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HeC51-0005Xd-GS for emacs-devel@gnu.org; Wed, 18 Apr 2007 11:28:23 -0400 Original-Received: from ch-smtp01.sth.basefarm.net ([80.76.149.212]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HeC09-0006mA-GE; Wed, 18 Apr 2007 11:23:21 -0400 Original-Received: from c83-254-145-24.bredband.comhem.se ([83.254.145.24]:62497 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.63) (envelope-from ) id 1HeC07-0002x8-5a; Wed, 18 Apr 2007 17:23:20 +0200 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.10) Gecko/20070221 Thunderbird/1.5.0.10 Mnenhy/0.7.5.666 In-Reply-To: X-Antivirus: avast! (VPS 000734-2, 2007-04-18), Outbound message X-Antivirus-Status: Clean X-Scan-Result: No virus found in message 1HeC07-0002x8-5a. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1HeC07-0002x8-5a fb9e0f5d5f47f60af38cae8360397bb7 X-detected-kernel: Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69568 Archived-At: Richard Stallman wrote: > Subject: The doc string for a globalized minor mode should linke to the mode > > I am not entirely sure what that means. Could you be more specific? > > Can you write a fix? I would prefer something like this: Index: easy-mmode.el =================================================================== RCS file: /sources/emacs/emacs/lisp/emacs-lisp/easy-mmode.el,v retrieving revision 1.82 diff -c -r1.82 easy-mmode.el *** easy-mmode.el 3 Feb 2007 17:26:28 -0000 1.82 --- easy-mmode.el 18 Apr 2007 15:22:58 -0000 *************** *** 295,301 **** call another major mode in their body." (let* ((global-mode-name (symbol-name global-mode)) - (pretty-name (easy-mmode-pretty-mode-name mode)) (pretty-global-name (easy-mmode-pretty-mode-name global-mode)) (group nil) (extra-keywords nil) --- 295,300 ---- *************** *** 327,337 **** (make-variable-buffer-local ',MODE-major-mode) ;; The actual global minor-mode (define-minor-mode ,global-mode ! ,(format "Toggle %s in every buffer. With prefix ARG, turn %s on if and only if ARG is positive. ! %s is actually not turned on in every buffer but only in those in which `%s' turns it on." ! pretty-name pretty-global-name pretty-name turn-on) :global t ,@group ,@(nreverse extra-keywords) ;; Setup hook to handle future mode changes and new buffers. --- 326,337 ---- (make-variable-buffer-local ',MODE-major-mode) ;; The actual global minor-mode (define-minor-mode ,global-mode ! ,(format "Toggle `%s' in every buffer. With prefix ARG, turn %s on if and only if ARG is positive. ! ! `%s' is actually not turned on in every buffer but only in those in which `%s' turns it on." ! mode pretty-global-name mode turn-on) :global t ,@group ,@(nreverse extra-keywords) ;; Setup hook to handle future mode changes and new buffers.