unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* The doc string for a globalized minor mode should linke to the mode
@ 2007-04-17 10:45 Lennart Borgman (gmail)
  2007-04-18  2:02 ` Richard Stallman
  0 siblings, 1 reply; 3+ messages in thread
From: Lennart Borgman (gmail) @ 2007-04-17 10:45 UTC (permalink / raw)
  To: Emacs Devel

It currently does not do that which is very impractical (and very 
"non-Emacs").

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: The doc string for a globalized minor mode should linke to the mode
  2007-04-17 10:45 The doc string for a globalized minor mode should linke to the mode Lennart Borgman (gmail)
@ 2007-04-18  2:02 ` Richard Stallman
  2007-04-18 15:23   ` Lennart Borgman (gmail)
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Stallman @ 2007-04-18  2:02 UTC (permalink / raw)
  To: Lennart Borgman (gmail); +Cc: emacs-devel

    Subject: The doc string for a globalized minor mode should linke to the mode

I am not entirely sure what that means.  Could you be more specific?

Can you write a fix?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: The doc string for a globalized minor mode should linke to the mode
  2007-04-18  2:02 ` Richard Stallman
@ 2007-04-18 15:23   ` Lennart Borgman (gmail)
  0 siblings, 0 replies; 3+ messages in thread
From: Lennart Borgman (gmail) @ 2007-04-18 15:23 UTC (permalink / raw)
  To: rms; +Cc: emacs-devel

Richard Stallman wrote:
>     Subject: The doc string for a globalized minor mode should linke to the mode
> 
> I am not entirely sure what that means.  Could you be more specific?
> 
> Can you write a fix?


I would prefer something like this:

Index: easy-mmode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/emacs-lisp/easy-mmode.el,v
retrieving revision 1.82
diff -c -r1.82 easy-mmode.el
*** easy-mmode.el	3 Feb 2007 17:26:28 -0000	1.82
--- easy-mmode.el	18 Apr 2007 15:22:58 -0000
***************
*** 295,301 ****
   call another major mode in their body."

     (let* ((global-mode-name (symbol-name global-mode))
- 	 (pretty-name (easy-mmode-pretty-mode-name mode))
   	 (pretty-global-name (easy-mmode-pretty-mode-name global-mode))
   	 (group nil)
   	 (extra-keywords nil)
--- 295,300 ----
***************
*** 327,337 ****
          (make-variable-buffer-local ',MODE-major-mode)
          ;; The actual global minor-mode
          (define-minor-mode ,global-mode
! 	 ,(format "Toggle %s in every buffer.
   With prefix ARG, turn %s on if and only if ARG is positive.
! %s is actually not turned on in every buffer but only in those
   in which `%s' turns it on."
! 		  pretty-name pretty-global-name pretty-name turn-on)
   	 :global t ,@group ,@(nreverse extra-keywords)

   	 ;; Setup hook to handle future mode changes and new buffers.
--- 326,337 ----
          (make-variable-buffer-local ',MODE-major-mode)
          ;; The actual global minor-mode
          (define-minor-mode ,global-mode
! 	 ,(format "Toggle `%s' in every buffer.
   With prefix ARG, turn %s on if and only if ARG is positive.
!
! `%s' is actually not turned on in every buffer but only in those
   in which `%s' turns it on."
! 		  mode pretty-global-name mode turn-on)
   	 :global t ,@group ,@(nreverse extra-keywords)

   	 ;; Setup hook to handle future mode changes and new buffers.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-04-18 15:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-17 10:45 The doc string for a globalized minor mode should linke to the mode Lennart Borgman (gmail)
2007-04-18  2:02 ` Richard Stallman
2007-04-18 15:23   ` Lennart Borgman (gmail)

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).