Re: [rudalics@gmx.at: whitespace.el's permanent-locals]

Re: [rudalics@gmx.at: whitespace.el's permanent-locals]

[martin rudalics]

> I failed to notice that the property being put on is nil, not t.
> These put calls are no-ops, since nil is the default.
> So it is fine if someone deletes them.

I removed them.

[rudalics@gmx.at: whitespace.el's permanent-locals]

[Richard Stallman]

What was the reason for marking these variables as permanent?

------- Start of forwarded message -------
X-Spam-Status: No, score=1.2 required=5.0 tests=RCVD_IN_SORBS_WEB,
	UNPARSEABLE_RELAY autolearn=no version=3.1.0
Date: Tue, 13 Mar 2007 23:09:41 +0100
From: martin rudalics <rudalics@gmx.at>
MIME-Version: 1.0
To: emacs-devel <emacs-devel@gnu.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Subject: whitespace.el's permanent-locals

whitespace.el has these lines:

     105:(put 'whitespace-mode 'permanent-local nil)
     110:(put 'whitespace-mode-line 'permanent-local nil)
     115:(put 'whitespace-check-buffer-leading 'permanent-local nil)
     120:(put 'whitespace-check-buffer-trailing 'permanent-local nil)
     125:(put 'whitespace-check-buffer-indent 'permanent-local nil)
     130:(put 'whitespace-check-buffer-spacetab 'permanent-local nil)
     135:(put 'whitespace-check-buffer-ateol 'permanent-local nil)
     140:(put 'whitespace-highlighted-space 'permanent-local nil)

I'd remove them.




_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
------- End of forwarded message -------

Re: [rudalics@gmx.at: whitespace.el's permanent-locals]

[Rajesh Vaidheeswarran]

If I remember the reason correctly, it was because  wanted the ability
to toggle on/off the check for and correct the various types of
whitespaces to be on a per-buffer basis.

If this is not the preferred way of achieving that result, I'd be
happy to change it to the preferred way if you (or someone) can tell
me how to.

rv

On 3/14/07, Richard Stallman <rms@gnu.org> wrote:
> What was the reason for marking these variables as permanent?
>
> ------- Start of forwarded message -------
> X-Spam-Status: No, score=1.2 required=5.0 tests=RCVD_IN_SORBS_WEB,
>         UNPARSEABLE_RELAY autolearn=no version=3.1.0
> Date: Tue, 13 Mar 2007 23:09:41 +0100
> From: martin rudalics <rudalics@gmx.at>
> MIME-Version: 1.0
> To: emacs-devel <emacs-devel@gnu.org>
> Content-Type: text/plain; charset=ISO-8859-15; format=flowed
> Subject: whitespace.el's permanent-locals
>
> whitespace.el has these lines:
>
>      105:(put 'whitespace-mode 'permanent-local nil)
>      110:(put 'whitespace-mode-line 'permanent-local nil)
>      115:(put 'whitespace-check-buffer-leading 'permanent-local nil)
>      120:(put 'whitespace-check-buffer-trailing 'permanent-local nil)
>      125:(put 'whitespace-check-buffer-indent 'permanent-local nil)
>      130:(put 'whitespace-check-buffer-spacetab 'permanent-local nil)
>      135:(put 'whitespace-check-buffer-ateol 'permanent-local nil)
>      140:(put 'whitespace-highlighted-space 'permanent-local nil)
>
> I'd remove them.
>
>
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel
> ------- End of forwarded message -------
>

Re: [rudalics@gmx.at: whitespace.el's permanent-locals]

[Miles Bader]

"Rajesh Vaidheeswarran" <rv@gnu.org> writes:
> If I remember the reason correctly, it was because  wanted the ability
> to toggle on/off the check for and correct the various types of
> whitespaces to be on a per-buffer basis.

Just make it a normal minor mode.  I see no reason to do otherwise.

Indeed, this is exactly the sort of minor-mode which is likely to get
put into hook functions for various major-modes because the user wants
to control whitespace in that mode.  In such a case (and I think it's
the most common one) the parameters are much more likely to be
_mode_-specific rather than buffer-specific.

-miles
-- 
Somebody has to do something, and it's just incredibly pathetic that it
has to be us.  -- Jerry Garcia

Re: [rudalics@gmx.at: whitespace.el's permanent-locals]

[Lennart Borgman (gmail)]

Miles Bader wrote:
> "Rajesh Vaidheeswarran" <rv@gnu.org> writes:
>> If I remember the reason correctly, it was because  wanted the ability
>> to toggle on/off the check for and correct the various types of
>> whitespaces to be on a per-buffer basis.
> 
> Just make it a normal minor mode.  I see no reason to do otherwise.
> 
> Indeed, this is exactly the sort of minor-mode which is likely to get
> put into hook functions for various major-modes because the user wants
> to control whitespace in that mode.  In such a case (and I think it's
> the most common one) the parameters are much more likely to be
> _mode_-specific rather than buffer-specific.
> 
> -miles


I agree. And a convenient way for the user to achive that is to use 
define-globalized-minor-mode and define his own globalized version of 
the minor mode.