From: Daniel Colascione <dancol@dancol.org>
To: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org
Subject: Re: pdumper test failures: invalid faces
Date: Fri, 16 Feb 2018 10:30:44 -0800 [thread overview]
Message-ID: <45aa9054-1641-4a3f-fc36-a83147b87ba6@dancol.org> (raw)
In-Reply-To: <scvaewssi4.fsf@fencepost.gnu.org>
On 02/16/2018 10:23 AM, Glenn Morris wrote:
>
> It's fantastic to see a portable dumper for Emacs!
>
> "make check" has a number of failures, which I assume are not specific
> to my machine. Many are to do with invalid faces. A minimal example
> might be:
>
> ./src/emacs -Q --batch --eval "(describe-face 'shadow)"
> -> "Invalid face: tooltip"
Thankfully, the tooltip face does exist when we start Emacs for
interactive use, so I suspect some kind of face-initialization
weirdness, not fundamental dump-restoration breakage.
> Unrelated:
> pdumper.c has no copyright header
> pdumper.h, fingerprint.h, fingerprint-dummy.c have outdated copyright years
> make-fingerprint.c has outdated and probably bogus years
Yeah. The pdumper branch will need a bit of cleanup and documentation
before we merge it into master.
next prev parent reply other threads:[~2018-02-16 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 18:23 pdumper test failures: invalid faces Glenn Morris
2018-02-16 18:30 ` Daniel Colascione [this message]
2018-02-26 6:27 ` Daniel Colascione
2018-02-26 7:22 ` Clément Pit-Claudel
2018-02-26 19:30 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45aa9054-1641-4a3f-fc36-a83147b87ba6@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).