unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: More visible mini-buffer prompt face
Date: Sat, 24 Feb 2007 02:35:51 +0100	[thread overview]
Message-ID: <45DF9677.9050104@gmail.com> (raw)
In-Reply-To: <E1HKgDd-0005fi-7M@fencepost.gnu.org>

Richard Stallman wrote:
>     I wonder if it would not be better to have a more visible face for the 
>     minibuffer prompt by default. My suggestion would be using a visible 
>     background color (some not too sharp yellow perhaps).
> 
> What color do you get now?

Dark blue text on white.

> Which of the options in the defface is being used?
> Could you propose a patch in that defface?

The face used is minibuffer-prompt, see below. I have made a new 
suggestion for the default. This is modelled after secondary-selection 
face to avoid to big surprises. For light background this face has a 
yellow background. AFAIU yellow is often used to draw attention on 
different signs in our culture and that makes it a good choice here.

I selected a somewhat darker yellow variant of the named colors which I 
personally find more pleasant. Though I do not know if this color fits 
the (min-colors 88).

However it does not seem that the support for my idea is very big at the 
moment ;-)


Index: faces.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v
retrieving revision 1.366
diff -u -r1.366 faces.el
--- faces.el	14 Feb 2007 15:31:09 -0000	1.366
+++ faces.el	23 Feb 2007 20:14:56 -0000
@@ -2134,12 +2134,20 @@
    :version "22.1"
    :group 'basic-faces)

+;; Modelled after secondary-selection face.
+;; Suggested on Emacs Devel as usual.
  (defface minibuffer-prompt
-  '((((background dark)) :foreground "cyan")
-    ;; Don't use blue because many users of the MS-DOS port customize
-    ;; their foreground color to be blue.
-    (((type pc)) :foreground "magenta")
-    (t :foreground "dark blue"))
+  '((((class color) (min-colors 88) (background light))
+     :background "gold")
+    (((class color) (min-colors 88) (background dark))
+     :background "SkyBlue4")
+    (((class color) (min-colors 16) (background light))
+     :background "yellow")
+    (((class color) (min-colors 16) (background dark))
+     :background "SkyBlue4")
+    (((class color) (min-colors 8))
+     :background "cyan" :foreground "black")
+    (t :inverse-video t))
    "Face for minibuffer prompts.
  By default, Emacs automatically adds this face to the value of
  `minibuffer-prompt-properties', which is a list of text properties

  parent reply	other threads:[~2007-02-24  1:35 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-23 16:24 More visible mini-buffer prompt face Lennart Borgman (gmail)
2007-02-23 16:41 ` Juanma Barranquero
2007-02-23 17:46   ` Lennart Borgman (gmail)
2007-02-23 18:09     ` Stefan Monnier
2007-02-23 19:36 ` Richard Stallman
2007-02-23 19:58   ` Drew Adams
2007-02-23 21:47     ` Lennart Borgman (gmail)
2007-02-24  0:18       ` Drew Adams
2007-02-24  1:01         ` Lennart Borgman (gmail)
2007-02-24  1:08           ` Drew Adams
2007-02-24  1:27             ` Lennart Borgman (gmail)
2007-02-24  8:28     ` Richard Stallman
2007-02-24 22:16       ` Kim F. Storm
2007-02-24  1:35   ` Lennart Borgman (gmail) [this message]
2007-02-24  4:30     ` Daniel Brockman
2007-02-24 18:51       ` Lennart Borgman (gmail)
2007-02-24 14:20     ` Miles Bader
2007-02-24 14:36       ` Eli Zaretskii
2007-02-25  4:06     ` Richard Stallman
2007-02-26  3:27     ` Richard Stallman
2007-02-26 10:55       ` Mathias Dahl
2007-02-26 16:48         ` Lennart Borgman (gmail)
2007-02-27  7:38         ` Richard Stallman
2007-02-24 17:58 ` Mathias Dahl
2007-02-25  1:09   ` Lennart Borgman (gmail)
2007-02-25 20:44     ` Lennart Borgman (gmail)
2007-02-25  4:06   ` Richard Stallman
2007-02-25 11:01     ` Mathias Dahl
2007-02-26  3:27       ` Richard Stallman
2007-02-26 10:45         ` Mathias Dahl
2007-02-26 11:20           ` Juanma Barranquero
2007-02-26 23:53             ` Mathias Dahl
2007-02-27 19:07         ` Stuart D. Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DF9677.9050104@gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).