unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
Cc: Emacs-Devel <emacs-devel@gnu.org>
Subject: Re: abbreviate-file-name on Windows seems incorrect
Date: Sat, 06 Jan 2007 12:37:25 +0100	[thread overview]
Message-ID: <459F89F5.3080504@gmail.com> (raw)
In-Reply-To: <BDEIJAFNGDOAGCJIPKPBGEMJCBAA.drew.adams@oracle.com>

Drew Adams wrote:
> On MS Windows, my $HOME is "c:\\". That is what is returned by (getenv
> "HOME"), and that is what I see in Windows itself, in the list of
> environment vars.
> 
> The code for `abbreviate-file-name' defines `abbreviated-home-dir' as
> follows, in order to be able to "substitute `~' for the user's home
> directory", as the doc string says:
> 
> (or abbreviated-home-dir
>     (setq abbreviated-home-dir
>           (let ((abbreviated-home-dir "$foo"))
>             (concat "^" (abbreviate-file-name
>                          (expand-file-name "~"))
>                     "\\(/\\|\\'\\)"))))
> 
> The comment for this code is as follows, which indicates that a slash is
> added to distinguish the home dir from a file in that dir:
> 
>     ;; We include a slash at the end, to avoid spurious matches
>     ;; such as `/usr/foobar' when the home dir is `/usr/foo'.
> 
> However, that is improper for a Windows home directory such as mine (not an
> uncommon value).  (expand-file-name "~") returns "c:/", which is correct,
> but the result for `abbreviated-home-dir' becomes "^c:/\\(/\\|\\'\\)", which
> is incorrect and useless, AFAICT. It should be something like
> "^c:\\(/\\|\\'\\)", I would think.
> 
> I would expect (abbreviate-file-name "c:/foo/bar") to return "~/foo/bar",
> but it returns "c:/foo/bar". If `abbreviated-home-dir' were
> "^c:\\(/\\|\\'\\)", then the result would be correct: "~/foo/bar".



If leave abbreviated-home-dir as "^c:/\\(/\\|\\'\\)" and you instead 
just comment out this part in abbreviate-file-name, does it works as you 
expect then? :

	       ;; MS-DOS root directories can come with a drive letter;
	       ;; Novell Netware allows drive letters beyond `Z:'.
	       (not (and (or (eq system-type 'ms-dos)
			     (eq system-type 'cygwin)
			     (eq system-type 'windows-nt))
			 (save-match-data
			   (string-match "^[a-zA-`]:/$" filename)))))

  reply	other threads:[~2007-01-06 11:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-06  7:56 abbreviate-file-name on Windows seems incorrect Drew Adams
2007-01-06 11:37 ` Lennart Borgman (gmail) [this message]
2007-01-06 14:18   ` Eli Zaretskii
2007-01-06 15:03     ` Lennart Borgman (gmail)
2007-01-06 11:56 ` Eli Zaretskii
2007-01-06 16:22   ` Drew Adams
2007-01-06 21:51     ` Eli Zaretskii
2007-01-06 22:42       ` Drew Adams
2007-01-07  2:44       ` Miles Bader
2007-01-07  4:12         ` Eli Zaretskii
2007-01-07 14:29           ` Stephen Leake
2007-01-07 20:47             ` Eli Zaretskii
2007-01-07 22:03               ` Drew Adams
2007-01-07 22:08                 ` Drew Adams
2007-01-08  1:40                   ` Chris Moore
2007-01-08  2:04                     ` Drew Adams
2007-01-08 10:15                       ` Jason Rumney
2007-01-08 16:29                         ` Drew Adams
2007-01-09  0:01                         ` Richard Stallman
2007-01-09  0:30                           ` Jason Rumney
2007-01-09 12:55                             ` Stephen Leake
2007-01-09 17:57                             ` Richard Stallman
2007-01-08  8:44               ` Stephen Leake
2007-01-08 13:07                 ` Chris Moore
2007-01-08 19:30                 ` Eli Zaretskii
2007-01-09 12:52                   ` Stephen Leake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=459F89F5.3080504@gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).