From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: convert-standard-filename on w32 does not preserve match-data?
Date: Wed, 27 Dec 2006 16:02:06 +0100 [thread overview]
Message-ID: <45928AEE.8030707@gmail.com> (raw)
In-Reply-To: <jwvlkktz8zk.fsf-monnier+emacs@gnu.org>
Stefan Monnier wrote:
> In thre particular case of convert-standard-filename, I think it would be
> wrong to add save-match-data (unless there's a particular reason to do it,
> of course), but I agree that it's not worth removing it either.
>
The code using convert-standard-filename probably already feels a bit
overloaded. convert-standard-filename is an "add on" to what one
actually tries to do and it is easily left out. Requiring the coder to
also add save-match-data seems like an unnecessary burden in this case
and I therefore think that convert-standard-filename should call
save-match-data internally.
next prev parent reply other threads:[~2006-12-27 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 22:17 convert-standard-filename on w32 does not preserve match-data? Lennart Borgman
2006-12-20 23:06 ` Stefan Monnier
2006-12-20 23:13 ` Lennart Borgman
2006-12-21 18:07 ` Richard Stallman
2006-12-22 23:33 ` Eli Zaretskii
2006-12-24 1:35 ` Richard Stallman
2006-12-25 23:19 ` Stefan Monnier
2006-12-26 17:22 ` Richard Stallman
2006-12-27 14:55 ` Stefan Monnier
2006-12-27 15:02 ` Lennart Borgman (gmail) [this message]
2006-12-27 16:08 ` Stefan Monnier
2006-12-27 17:46 ` Lennart Borgman (gmail)
2006-12-29 21:02 ` Stefan Monnier
2006-12-29 21:54 ` Lennart Borgman (gmail)
2006-12-28 17:19 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45928AEE.8030707@gmail.com \
--to=lennart.borgman@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).