From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: Problems with the url package on w32? Date: Fri, 22 Dec 2006 00:13:24 +0100 Message-ID: <458B1514.4070902@student.lu.se> References: <87wt5825wh.fsf@freemail.hu> <45887987.3040105@student.lu.se> NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1166742834 30634 80.91.229.10 (21 Dec 2006 23:13:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 21 Dec 2006 23:13:54 +0000 (UTC) Cc: Juanma Barranquero , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 22 00:13:52 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1GxX6g-0005Us-8m for ged-emacs-devel@m.gmane.org; Fri, 22 Dec 2006 00:13:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GxX6f-00006x-KC for ged-emacs-devel@m.gmane.org; Thu, 21 Dec 2006 18:13:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GxX6T-000067-3k for emacs-devel@gnu.org; Thu, 21 Dec 2006 18:13:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GxX6R-00005I-Js for emacs-devel@gnu.org; Thu, 21 Dec 2006 18:13:32 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GxX6R-000054-G2 for emacs-devel@gnu.org; Thu, 21 Dec 2006 18:13:31 -0500 Original-Received: from [80.76.149.212] (helo=ch-smtp01.sth.basefarm.net) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GxX6Q-0001GO-0x for emacs-devel@gnu.org; Thu, 21 Dec 2006 18:13:30 -0500 Original-Received: from c83-254-145-24.bredband.comhem.se ([83.254.145.24]:62459 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.63) (envelope-from ) id 1GxX6K-0007XR-4E; Fri, 22 Dec 2006 00:13:24 +0100 User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) Original-To: Stefan Monnier In-Reply-To: X-Antivirus: avast! (VPS 0661-1, 2006-12-21), Outbound message X-Antivirus-Status: Clean X-Scan-Result: No virus found in message 1GxX6K-0007XR-4E. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1GxX6K-0007XR-4E 365b21925876d303f231994addeef4d6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:64074 Archived-At: Stefan Monnier wrote: >>> If you know of any other problem, please report it, >>> > > >> What I've seen many times is like your third item, but the hunks are >> not necessarily big. >> > > I.e. C-c C-a fails to apply the hunk (i.e. doesn't change the buffer at > all), and correctly tells the user about this failure? > > If so, it's a "minor" bug. > I think that on w32 several things can happen. The main problem is the line endings and the ability of different patch.exe on w32 to handle them. I sent a link to my tests earlier. They are probably difficult to understand by just reading that page, I can't even remember myself anymore. However I do have a suggestion: It would be good to have a function in emacs handling the problems with different line endings for patch. This could be used for diff-apply-hunk and other similar functions in ediff. This function could do something like this: 1) read the file(s) to patch and the patch. 2) if line endings are the same and can be used by the tools just apply the patch 3) otherwise write rewrite the files with new line endings as needed and apply the patch. Switch back to old line endings for the patched file if necessary. Without something like this I think we can not get patch to work from emacs reliable on w32. It would be a benefit for other platforms be able to I believe.