From: Lennart Borgman <lennart.borgman.073@student.lu.se>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: convert-standard-filename on w32 does not preserve match-data?
Date: Thu, 21 Dec 2006 00:13:12 +0100 [thread overview]
Message-ID: <4589C388.1020509@student.lu.se> (raw)
In-Reply-To: <jwvvek6dv8h.fsf-monnier+emacs@gnu.org>
Stefan Monnier wrote:
>> Should not the whole body of convert-standard-filename in w32-fns.el be
>> protected by save-match-data? Does not match-string set match-data?
>>
>
> No, I think instead that code that calls convert-standard-filename shouldn't
> expect it to preserve the match-data.
> Could you point us to the code that incorrectly expects it to preserve the
> match data, or at least to a case where your suggested change fixes a bug?
>
There is already a call to save-match-data in convert-standard-filename
in w32-fns.el. I am just saying that it is in the wrong place.
Useless. And I can't understand why it should not protect match-data?
next prev parent reply other threads:[~2006-12-20 23:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 22:17 convert-standard-filename on w32 does not preserve match-data? Lennart Borgman
2006-12-20 23:06 ` Stefan Monnier
2006-12-20 23:13 ` Lennart Borgman [this message]
2006-12-21 18:07 ` Richard Stallman
2006-12-22 23:33 ` Eli Zaretskii
2006-12-24 1:35 ` Richard Stallman
2006-12-25 23:19 ` Stefan Monnier
2006-12-26 17:22 ` Richard Stallman
2006-12-27 14:55 ` Stefan Monnier
2006-12-27 15:02 ` Lennart Borgman (gmail)
2006-12-27 16:08 ` Stefan Monnier
2006-12-27 17:46 ` Lennart Borgman (gmail)
2006-12-29 21:02 ` Stefan Monnier
2006-12-29 21:54 ` Lennart Borgman (gmail)
2006-12-28 17:19 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4589C388.1020509@student.lu.se \
--to=lennart.borgman.073@student.lu.se \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).