Select and Paste

Select and Paste

[Lennart Borgman]

is a very nice feature to have in the menus but maybe not the best name 
for it since "Select" in nearly the same context refers to selecting 
text in the buffer.

Maybe "Paste More"?

BTW "Paste" is enabled when you are in an info buffer, but "Select and 
Paste" is not.

Re: Select and Paste

[Richard Stallman]

    is a very nice feature to have in the menus but maybe not the best name 
    for it since "Select" in nearly the same context refers to selecting 
    text in the buffer.

    Maybe "Paste More"?

How about Paste Menu?

    BTW "Paste" is enabled when you are in an info buffer, but "Select and 
    Paste" is not.

That seems like a bug, but it doesn't happen when I try it,
and the code checks buffer-read-only.  Can you debug why it
fails for you?

Re: Select and Paste

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Date: Thu, 30 Nov 2006 14:48:43 -0500
> Cc: emacs-devel@gnu.org
> 
>     is a very nice feature to have in the menus but maybe not the best name 
>     for it since "Select" in nearly the same context refers to selecting 
>     text in the buffer.
> 
>     Maybe "Paste More"?
> 
> How about Paste Menu?

How about "Paste From Menu"?

>     BTW "Paste" is enabled when you are in an info buffer, but "Select and 
>     Paste" is not.
> 
> That seems like a bug, but it doesn't happen when I try it,
> and the code checks buffer-read-only.  Can you debug why it
> fails for you?

The fact that Paste and Select and Paste behave differently is not a
bug: Paste could be enabled because Emacs sees text in the X selection
(or the Windows clipboard).  In that case, if the Emacs kill-ring is
empty, Select and Paste will be disabled.

As for the buffer-read-only test, I see that it doesn't work in more
than just Paste: for example, Cut also becomes enabled when I mark a
region in a read-only buffer.  I didn't have time to debug this,
though.

Re: Select and Paste

[Kim F. Storm]

Eli Zaretskii <eliz@gnu.org> writes:

>> How about Paste Menu?
>
> How about "Paste From Menu"?

or:

Paste from kill-ring  ?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Select and Paste

[Lennart Borgman]

Kim F. Storm wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
> 
>>> How about Paste Menu?
>> How about "Paste From Menu"?
> 
> or:
> 
> Paste from kill-ring  ?

That is a killer suggestion. I like it.

Re: Select and Paste

[Richard Stallman]

    > Paste from kill-ring  ?

    That is a killer suggestion. I like it.

All yanking comes from the kill-ring, so "Paste from kill-ring" does not
really say how this is different from "Paste".

Re: Select and Paste

[Lennart Borgman]

Richard Stallman wrote:
>     > Paste from kill-ring  ?
> 
>     That is a killer suggestion. I like it.
> 
> All yanking comes from the kill-ring, so "Paste from kill-ring" does not
> really say how this is different from "Paste".


But a difference is that when you choose Paste it could come from other 
programs too. So I think "Paste from kill-ring" is a good suggestion.

Re: Select and Paste

[Richard Stallman]

    > That seems like a bug, but it doesn't happen when I try it,
    > and the code checks buffer-read-only.  Can you debug why it
    > fails for you?

    The fact that Paste and Select and Paste behave differently is not a
    bug: Paste could be enabled because Emacs sees text in the X selection
    (or the Windows clipboard).  In that case, if the Emacs kill-ring is
    empty, Select and Paste will be disabled.

Both of these have conditions of the form (and ... (not buffer-read-only)),
so I don't see how either of them could be enabled in a read-only buffer
regardless of other circumstances.

The same is true of Cut.

Can anyone debug this?  Does anyone else see it fail this way?

Re: Select and Paste

[martin rudalics]

 >     > That seems like a bug, but it doesn't happen when I try it,
 >     > and the code checks buffer-read-only.  Can you debug why it
 >     > fails for you?
 >
 >     The fact that Paste and Select and Paste behave differently is not a
 >     bug: Paste could be enabled because Emacs sees text in the X selection
 >     (or the Windows clipboard).  In that case, if the Emacs kill-ring is
 >     empty, Select and Paste will be disabled.
 >
 > Both of these have conditions of the form (and ... (not buffer-read-only)),
 > so I don't see how either of them could be enabled in a read-only buffer
 > regardless of other circumstances.
 >
 > The same is true of Cut.

Maybe because the key definitions come from `menu-bar-enable-clipboard'.

Re: Select and Paste

[Richard Stallman]

    Maybe because the key definitions come from `menu-bar-enable-clipboard'.

That could be it.  For sure, those definitions should have suitable
:enable conditions.

Can you add some?

Re: Select and Paste

[martin rudalics]

[-- Attachment #1: Type: text/plain, Size: 64 bytes --]

Could people try whether the attached patch gives good results?

[-- Attachment #2: menu-bar.patch --]
[-- Type: text/plain, Size: 1253 bytes --]

*** menu-bar.el.~1.296.~	Sun Nov 19 18:04:18 2006
--- menu-bar.el	Sun Dec  3 11:00:30 2006
***************
*** 502,512 ****
  ;; These are alternative definitions for the cut, paste and copy
  ;; menu items.  Use them if your system expects these to use the clipboard.

! (put 'clipboard-kill-region 'menu-enable 'mark-active)
  (put 'clipboard-kill-ring-save 'menu-enable 'mark-active)
  (put 'clipboard-yank 'menu-enable
!      '(or (and (fboundp 'x-selection-exists-p) (x-selection-exists-p))
! 	  (x-selection-exists-p 'CLIPBOARD)))

  (defun clipboard-yank ()
    "Insert the clipboard contents, or the last stretch of killed text."
--- 502,515 ----
  ;; These are alternative definitions for the cut, paste and copy
  ;; menu items.  Use them if your system expects these to use the clipboard.

! (put 'clipboard-kill-region 'menu-enable
!      '(and mark-active (not buffer-read-only)))
  (put 'clipboard-kill-ring-save 'menu-enable 'mark-active)
  (put 'clipboard-yank 'menu-enable
!      '(and (or (and (fboundp 'x-selection-exists-p)
! 		    (x-selection-exists-p))
! 	       (x-selection-exists-p 'CLIPBOARD))
! 	   (not buffer-read-only)))

  (defun clipboard-yank ()
    "Insert the clipboard contents, or the last stretch of killed text."

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Select and Paste

[Lennart Borgman]

Richard Stallman wrote:
>     is a very nice feature to have in the menus but maybe not the best name 
>     for it since "Select" in nearly the same context refers to selecting 
>     text in the buffer.
> 
>     Maybe "Paste More"?
> 
> How about Paste Menu?
> 
>     BTW "Paste" is enabled when you are in an info buffer, but "Select and 
>     Paste" is not.
> 
> That seems like a bug, but it doesn't happen when I try it,
> and the code checks buffer-read-only.  Can you debug why it
> fails for you?



If I start with

    emacs -Q

and go into an Info buffer then the "Paste" entry in the Options menu in 
the menu bar is enabled. I am using w32. So this does not happen on 
GNU/Linux?

Could someone tell me where the code is that should enable/disable the 
"Paste" entry? I tried to find it but it was not that simple.

Re: Select and Paste

[Stuart D. Herring]

> Could someone tell me where the code is that should enable/disable the
> "Paste" entry? I tried to find it but it was not that simple.

Look in menu-bar.el.  The :enable predicates control those menu entries,
which you can find just by searching for their names.  Unfortunately, I
don't see the bug there myself.

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

Re: Select and Paste

[Richard Stallman]

    If I start with

	emacs -Q

    and go into an Info buffer then the "Paste" entry in the Options menu in 
    the menu bar is enabled. I am using w32. So this does not happen on 
    GNU/Linux?

It does not happen for me.

    Could someone tell me where the code is that should enable/disable the 
    "Paste" entry? I tried to find it but it was not that simple.

menu-bar.el.