From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vinicius Jose Latorre Newsgroups: gmane.emacs.devel Subject: Re: [ben@redfrontdoor.org: Patch: minor display glitch with show-paren-mode] Date: Fri, 01 Dec 2006 19:04:41 -0200 Message-ID: <457098E9.4020701@ig.com.br> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1165007083 1396 80.91.229.2 (1 Dec 2006 21:04:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 1 Dec 2006 21:04:43 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 01 22:04:40 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GqFYj-0007e8-6a for ged-emacs-devel@m.gmane.org; Fri, 01 Dec 2006 22:04:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GqFYi-00043F-Rm for ged-emacs-devel@m.gmane.org; Fri, 01 Dec 2006 16:04:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GqFYY-00041G-27 for emacs-devel@gnu.org; Fri, 01 Dec 2006 16:04:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GqFYX-00040a-1q for emacs-devel@gnu.org; Fri, 01 Dec 2006 16:04:25 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GqFYW-00040X-VB for emacs-devel@gnu.org; Fri, 01 Dec 2006 16:04:24 -0500 Original-Received: from [200.221.4.198] (helo=smtp.uol.com.br) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GqFYS-0006FD-Uu; Fri, 01 Dec 2006 16:04:21 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by socom1.uol.com.br (Postfix) with ESMTP id E905D1000705; Fri, 1 Dec 2006 19:04:19 -0200 (BRST) Original-Received: from [201.72.53.218] (unknown [201.72.53.218]) by socom1.uol.com.br (Postfix) with ESMTP id BEBEA10002C7; Fri, 1 Dec 2006 19:04:18 -0200 (BRST) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061029 SeaMonkey/1.0.6 Original-To: rms@gnu.org In-Reply-To: X-SIG5: a93f1255179c437bed8beef850cb51bd X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:63204 Archived-At: Richard Stallman wrote: > Would someone please install this, then ack? > > ------- Start of forwarded message ------- > Date: Tue, 28 Nov 2006 11:54:26 +0000 > From: Ben North > To: emacs-devel@gnu.org > MIME-Version: 1.0 > Content-Type: text/plain; charset=ISO-8859-1 > Subject: Patch: minor display glitch with show-paren-mode > X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed > version=3.0.4 > > When using `show-paren-mode', I've noticed a slight problem: suppose you > have show-paren-mode turned on, and point is at -!- in the following: > > (setq a -!-(car b)) > > Then the opening and closing parens of `(car b)' are both highlighted. > Now type a few characters quickly. If you are quick enough, the > characters you type are also highlighted, because the overlay which > highlights the `(' has not yet had a chance to be moved. The tiny patch > below (against CVS HEAD, rev 1.69) makes the two relevant overlays > front-advancing, which seems to fix the problem. > > > > - --- ORIG/paren.el 2006-11-28 11:14:46.840839000 +0000 > +++ NEW/paren.el 2006-11-28 11:16:16.059970000 +0000 > @@ -220,7 +220,7 @@ > (point)))) > (if show-paren-overlay-1 > (move-overlay show-paren-overlay-1 from to (current-buffer)) > - - (setq show-paren-overlay-1 (make-overlay from to))) > + (setq show-paren-overlay-1 (make-overlay from to nil t))) > ;; Always set the overlay face, since it varies. > (overlay-put show-paren-overlay-1 'priority show-paren-priority) > (overlay-put show-paren-overlay-1 'face face))) > @@ -243,7 +243,7 @@ > (forward-point (- dir)))))) > (if show-paren-overlay > (move-overlay show-paren-overlay from to (current-buffer)) > - - (setq show-paren-overlay (make-overlay from to)))) > + (setq show-paren-overlay (make-overlay from to nil t)))) > ;; > ;; Always set the overlay face, since it varies. > (overlay-put show-paren-overlay 'priority show-paren-priority) > Done