From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: Incorrect declarations of thread functions on w32 Date: Mon, 27 Nov 2006 10:16:04 +0100 Message-ID: <456AACD4.1000808@student.lu.se> References: <456A510B.1080202@student.lu.se> <456AA968.8090609@gnu.org> <456AA9C6.1060304@student.lu.se> <456AAA5A.2010702@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1164619016 8354 80.91.229.2 (27 Nov 2006 09:16:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Nov 2006 09:16:56 +0000 (UTC) Cc: Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 27 10:16:55 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GocbW-0005vF-Ob for ged-emacs-devel@m.gmane.org; Mon, 27 Nov 2006 10:16:47 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GocbW-0008Nr-73 for ged-emacs-devel@m.gmane.org; Mon, 27 Nov 2006 04:16:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gocaw-00084x-Ij for emacs-devel@gnu.org; Mon, 27 Nov 2006 04:16:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gocau-00082y-NL for emacs-devel@gnu.org; Mon, 27 Nov 2006 04:16:09 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gocau-00082a-ID for emacs-devel@gnu.org; Mon, 27 Nov 2006 04:16:08 -0500 Original-Received: from [80.76.149.213] (helo=ch-smtp02.sth.basefarm.net) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Gocas-0000Bw-Ov; Mon, 27 Nov 2006 04:16:07 -0500 Original-Received: from c83-254-145-24.bredband.comhem.se ([83.254.145.24]:59577 helo=[192.168.123.121]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.63) (envelope-from ) id 1Gocaq-0004nl-9X; Mon, 27 Nov 2006 10:16:05 +0100 User-Agent: Thunderbird 1.5.0.8 (Windows/20061025) Original-To: Jason Rumney In-Reply-To: <456AAA5A.2010702@gnu.org> X-Scan-Result: No virus found in message 1Gocaq-0004nl-9X. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1Gocaq-0004nl-9X 374ee8413bf62d1f984fd49402a0995a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62849 Archived-At: Jason Rumney wrote: > Lennart Borgman wrote: >>> Which thread functions are you talking about? >> >> The function arguments to CreateThread. > > Please, if you're going to report a bug, give us the details you found, > don't expect other people to go chasing after some vague detail like this. I thought I had given enough information when saying this. In the message before I told how the declaration should look according to MS. w32_msg_worker should have a declaration that looks like DWORD WINAPI ThreadProc( LPVOID lpParameter ); where ThreadProc should be replaced with w32_msg_worker. The same for reader_thread. Perhaps the declarations boils down to correct declarations under some circumstances, but I believe they should be changed since errors that bad declarations produce might be very hard to find. (Memory corruption etc.) And DWORD w32_msg_worker (); in w32_term.c is simply wrong.