From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [konrad.podczeck@univie.ac.at: flyspell bug] Date: Mon, 23 Oct 2006 08:17:30 +0200 Message-ID: <453C5E7A.1060302@gmx.at> References: <453A250E.3030306@gmx.at> <87zmbot4we.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060009070107070107010709" X-Trace: sea.gmane.org 1161584426 11574 80.91.229.2 (23 Oct 2006 06:20:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Oct 2006 06:20:26 +0000 (UTC) Cc: emacs-devel@gnu.org, rms@gnu.org, konrad.podczeck@univie.ac.at Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 23 08:20:21 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GbtAQ-0002fo-N1 for ged-emacs-devel@m.gmane.org; Mon, 23 Oct 2006 08:20:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GbtAQ-00064f-59 for ged-emacs-devel@m.gmane.org; Mon, 23 Oct 2006 02:20:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gbt9S-0005Cx-Q2 for emacs-devel@gnu.org; Mon, 23 Oct 2006 02:19:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gbt9R-0005BI-7N for emacs-devel@gnu.org; Mon, 23 Oct 2006 02:19:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gbt9Q-0005Aq-O6 for emacs-devel@gnu.org; Mon, 23 Oct 2006 02:19:08 -0400 Original-Received: from [213.165.64.20] (helo=mail.gmx.net) by monty-python.gnu.org with smtp (Exim 4.52) id 1Gbt9Q-0001NE-G0 for emacs-devel@gnu.org; Mon, 23 Oct 2006 02:19:08 -0400 Original-Received: (qmail invoked by alias); 23 Oct 2006 06:19:07 -0000 Original-Received: from N813P015.adsl.highway.telekom.at (EHLO [62.47.45.143]) [62.47.45.143] by mail.gmx.net (mp021) with SMTP; 23 Oct 2006 08:19:07 +0200 X-Authenticated: #14592706 User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en Original-To: Chong Yidong In-Reply-To: <87zmbot4we.fsf@stupidchicken.com> X-Y-GMX-Trusted: 0 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61025 Archived-At: This is a multi-part message in MIME format. --------------060009070107070107010709 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit > The patch looks right; I've checked it in. Konrad has detected a bug in it: >> However there is a new bug now: Duplicated words that are separated by >> a newline-character (e.g. "bug" at the end of some line and "bug" at >> the beginning of the following line) are no longer detected. Attached find a version that hopefully resolves this. I apologize for the inconvenience. --------------060009070107070107010709 Content-Type: text/plain; name="flyspell.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="flyspell.patch" *** flyspell.el Sat Oct 21 11:36:32 2006 --- flyspell.el Sun Oct 22 22:10:54 2006 *************** *** 1011,1021 **** (not (memq (char-after (1- start)) '(?\} ?\\))))) flyspell-mark-duplications-flag (save-excursion ! (goto-char (1- start)) ! (let ((p (flyspell-word-search-backward ! word ! (- start (1+ (- end start)))))) ! (and p (/= p (1- start)))))) ;; yes, this is a doublon (flyspell-highlight-incorrect-region start end 'doublon) nil) --- 1011,1022 ---- (not (memq (char-after (1- start)) '(?\} ?\\))))) flyspell-mark-duplications-flag (save-excursion ! (goto-char start) ! (let* ((bound ! (- start (- end start) (- (skip-chars-backward " \t\n\f")))) ! (p (when (>= bound (point-min)) ! (flyspell-word-search-backward word bound)))) ! (and p (/= p start))))) ;; yes, this is a doublon (flyspell-highlight-incorrect-region start end 'doublon) nil) *************** *** 1472,1478 **** (flyspell-word) ; Make sure current word is checked (backward-word 1) (while (and (< (point) end) ! (re-search-forward "\\b\\([^ \n\t]+\\)[ \n\t]+\\1\\b" end 'move)) (flyspell-word) (backward-word 1)) --- 1473,1479 ---- (flyspell-word) ; Make sure current word is checked (backward-word 1) (while (and (< (point) end) ! (re-search-forward "\\<\\(\\w+\\)\\>[ \n\t\f]+\\1\\>" end 'move)) (flyspell-word) (backward-word 1)) *************** *** 1708,1714 **** ;; now we can use a new overlay (setq flyspell-overlay (make-flyspell-overlay ! beg end 'flyspell-incorrect 'highlight))))))) ;;*---------------------------------------------------------------------*/ ;;* flyspell-highlight-duplicate-region ... */ --- 1709,1717 ---- ;; now we can use a new overlay (setq flyspell-overlay (make-flyspell-overlay ! beg end ! (if (eq poss 'doublon) 'flyspell-duplicate 'flyspell-incorrect) ! 'highlight))))))) ;;*---------------------------------------------------------------------*/ ;;* flyspell-highlight-duplicate-region ... */ --------------060009070107070107010709 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --------------060009070107070107010709--