From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Problem with quoting in shell-command called from ediff-directories Date: Wed, 04 Oct 2006 16:52:37 +0200 Message-ID: <4523CAB5.1090301@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1159973621 15009 80.91.229.2 (4 Oct 2006 14:53:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 4 Oct 2006 14:53:41 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 04 16:53:37 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GV87C-0007me-PU for ged-emacs-devel@m.gmane.org; Wed, 04 Oct 2006 16:52:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GV87C-0000tD-8P for ged-emacs-devel@m.gmane.org; Wed, 04 Oct 2006 10:52:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GV870-0000sS-9M for emacs-devel@gnu.org; Wed, 04 Oct 2006 10:52:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GV86z-0000s1-2e for emacs-devel@gnu.org; Wed, 04 Oct 2006 10:52:42 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GV86y-0000rx-Ux for emacs-devel@gnu.org; Wed, 04 Oct 2006 10:52:40 -0400 Original-Received: from [81.228.11.98] (helo=pne-smtpout1-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GV8DQ-00083x-Hi for emacs-devel@gnu.org; Wed, 04 Oct 2006 10:59:20 -0400 Original-Received: from [192.168.123.121] (83.249.218.244) by pne-smtpout1-sn1.fre.skanova.net (7.2.076) id 451ECC1B000F1F70; Wed, 4 Oct 2006 16:52:38 +0200 User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) Original-To: Emacs Devel , Michael Kifer X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60413 Archived-At: Here is another bug that depends on the problems with quoting. This time it is in `shell-command' that is called `ediff-append-custom-diff'. The file parameters need to be quoted but they are not. If I understand our last discussion on quoting and different shells (on w32 escpecially) all that is needed is to use `shell-quote-argument' on those file parameters. Is that correct? Could you please add that, Michael? Maybe there also should be a note in the doc string for `shell-command' about the need to use `shell-quote-argument' for file parameters?